Apply image transformation for thumbnails loaded by loadDetachedImage.

Apply image transformation for thumbnails loaded by loadDetachedImage.

This change will fix 2 parts where we had wrong image orientation,
when there's EXIF image rotation/transfomration info.
1. Tooltip thumbnail when an image is dragged in Files app.
2. Low-density image tentatively shown in Gallery app.

The drag thumbnail is changed to use the CANVAS mode,
because the IMAGE mode still doesn't work correctly.

BUG=680420, 680414
TEST=browser_tests --gtest_filter=FileManagerJsTest.ThumbnailLoader
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2630283002
Cr-Commit-Position: refs/heads/master@{#443875}
Committed: https://chromium.googlesource.com/chromium/src/+/b1a8ea6390809eb8e166631a05eaf97406baf6ca

[yamaguchi, 2017-01-16 10:01:59]

Description was changed from

==========
Apply image transformation for thumbnails loaded by loadDetachedImage.

This change will fix 2 parts where we had wrong image orientation,
when there's EXIF image rotation/transfomration info.
1. Tooltip thumbnail when an image is dragged in Files app.
2. Low-density image tentatively shown in Gallery app.

The drag thumbnail is changed to use the CANVAS mode,
because the IMAGE mode still doesn't work correctly.

BUG=680420,680414
==========

to

==========
Apply image transformation for thumbnails loaded by loadDetachedImage.

This change will fix 2 parts where we had wrong image orientation,
when there's EXIF image rotation/transfomration info.
1. Tooltip thumbnail when an image is dragged in Files app.
2. Low-density image tentatively shown in Gallery app.

The drag thumbnail is changed to use the CANVAS mode,
because the IMAGE mode still doesn't work correctly.

BUG=680420,680414
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[yamaguchi, 2017-01-16 10:07:35]

Description was changed from

==========
Apply image transformation for thumbnails loaded by loadDetachedImage.

This change will fix 2 parts where we had wrong image orientation,
when there's EXIF image rotation/transfomration info.
1. Tooltip thumbnail when an image is dragged in Files app.
2. Low-density image tentatively shown in Gallery app.

The drag thumbnail is changed to use the CANVAS mode,
because the IMAGE mode still doesn't work correctly.

BUG=680420,680414
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Apply image transformation for thumbnails loaded by loadDetachedImage.

This change will fix 2 parts where we had wrong image orientation,
when there's EXIF image rotation/transfomration info.
1. Tooltip thumbnail when an image is dragged in Files app.
2. Low-density image tentatively shown in Gallery app.

The drag thumbnail is changed to use the CANVAS mode,
because the IMAGE mode still doesn't work correctly.

BUG=680420,680414
TEST=browser_tests --gtest_filter=FileManagerJsTest.ThumbnailLoader
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[yamaguchi, 2017-01-16 10:16:01]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 10:16:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yamaguchi, 2017-01-16 10:21:18]

yamaguchi@chromium.org changed reviewers:
+ oka@chromium.org

[yamaguchi, 2017-01-16 10:21:19]

ptal

[oka, 2017-01-16 11:58:10]

lgtm

https://codereview.chromium.org/2630283002/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/thumbnail_loader.js (right):

https://codereview.chromium.org/2630283002/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/thumbnail_loader.js:546: if
(this.loaderType_ === ThumbnailLoader.LoaderType.IMAGE)
Can the image be not properly oriented? If so, please add a todo to fix this
here.

[yamaguchi, 2017-01-16 12:13:54]

https://codereview.chromium.org/2630283002/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/thumbnail_loader.js (right):

https://codereview.chromium.org/2630283002/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/thumbnail_loader.js:546: if
(this.loaderType_ === ThumbnailLoader.LoaderType.IMAGE)
On 2017/01/16 11:58:09, oka wrote:
> Can the image be not properly oriented? If so, please add a todo to fix this
> here.

Yes. Added TODO.

[yamaguchi, 2017-01-16 12:17:35]

The CQ bit was checked by yamaguchi@chromium.org

[yamaguchi, 2017-01-16 12:17:36]

The patchset sent to the CQ was uploaded after l-g-t-m from oka@chromium.org
Link to the patchset: https://codereview.chromium.org/2630283002/#ps60001
(title: "Add comment.")

[commit-bot: I haz the power, 2017-01-16 12:17:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2017-01-16 12:30:55]

https://codereview.chromium.org/2630283002/diff/60001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/thumbnail_loader.js (right):

https://codereview.chromium.org/2630283002/diff/60001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/thumbnail_loader.js:329: * @param
{number} width width of the original image
nit: Width of the ...? (instead of width).

https://codereview.chromium.org/2630283002/diff/60001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/thumbnail_loader.js:330: * @param
{number} height height of the original image
nit: Height of the ...? (instead of height).

[commit-bot: I haz the power, 2017-01-16 12:43:29]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484569055829750,
"parent_rev": "ccdc3f3aef6ac41aba49b35a754e24961ace471a", "commit_rev":
"b1a8ea6390809eb8e166631a05eaf97406baf6ca"}

[commit-bot: I haz the power, 2017-01-16 12:43:58]

Description was changed from

==========
Apply image transformation for thumbnails loaded by loadDetachedImage.

This change will fix 2 parts where we had wrong image orientation,
when there's EXIF image rotation/transfomration info.
1. Tooltip thumbnail when an image is dragged in Files app.
2. Low-density image tentatively shown in Gallery app.

The drag thumbnail is changed to use the CANVAS mode,
because the IMAGE mode still doesn't work correctly.

BUG=680420,680414
TEST=browser_tests --gtest_filter=FileManagerJsTest.ThumbnailLoader
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Apply image transformation for thumbnails loaded by loadDetachedImage.

This change will fix 2 parts where we had wrong image orientation,
when there's EXIF image rotation/transfomration info.
1. Tooltip thumbnail when an image is dragged in Files app.
2. Low-density image tentatively shown in Gallery app.

The drag thumbnail is changed to use the CANVAS mode,
because the IMAGE mode still doesn't work correctly.

BUG=680420,680414
TEST=browser_tests --gtest_filter=FileManagerJsTest.ThumbnailLoader
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2630283002
Cr-Commit-Position: refs/heads/master@{#443875}
Committed:
https://chromium.googlesource.com/chromium/src/+/b1a8ea6390809eb8e166631a05ea...
==========

[commit-bot: I haz the power, 2017-01-16 12:43:59]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/b1a8ea6390809eb8e166631a05ea...

[yamaguchi, 2017-01-18 07:50:13]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2640743002/ by yamaguchi@chromium.org.

The reason for reverting is: crbug.com/682139.