Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2630283002: Apply image transformation for thumbnails loaded by loadDetachedImage. (Closed)

Created:
3 years, 11 months ago by yamaguchi
Modified:
3 years, 11 months ago
Reviewers:
oka
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Apply image transformation for thumbnails loaded by loadDetachedImage. This change will fix 2 parts where we had wrong image orientation, when there's EXIF image rotation/transfomration info. 1. Tooltip thumbnail when an image is dragged in Files app. 2. Low-density image tentatively shown in Gallery app. The drag thumbnail is changed to use the CANVAS mode, because the IMAGE mode still doesn't work correctly. BUG=680420, 680414 TEST=browser_tests --gtest_filter=FileManagerJsTest.ThumbnailLoader CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2630283002 Cr-Commit-Position: refs/heads/master@{#443875} Committed: https://chromium.googlesource.com/chromium/src/+/b1a8ea6390809eb8e166631a05eaf97406baf6ca

Patch Set 1 #

Patch Set 2 : Fix the unittest. Only CANVAS mode works correctly now. #

Patch Set 3 : Revise comment #

Total comments: 2

Patch Set 4 : Add comment. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -31 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_transfer_controller.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/thumbnail_loader.js View 1 2 3 5 chunks +55 lines, -30 lines 2 comments Download
M ui/file_manager/file_manager/foreground/js/thumbnail_loader_unittest.js View 1 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
yamaguchi
ptal
3 years, 11 months ago (2017-01-16 10:21:19 UTC) #6
oka
lgtm https://codereview.chromium.org/2630283002/diff/40001/ui/file_manager/file_manager/foreground/js/thumbnail_loader.js File ui/file_manager/file_manager/foreground/js/thumbnail_loader.js (right): https://codereview.chromium.org/2630283002/diff/40001/ui/file_manager/file_manager/foreground/js/thumbnail_loader.js#newcode546 ui/file_manager/file_manager/foreground/js/thumbnail_loader.js:546: if (this.loaderType_ === ThumbnailLoader.LoaderType.IMAGE) Can the image be ...
3 years, 11 months ago (2017-01-16 11:58:10 UTC) #7
yamaguchi
https://codereview.chromium.org/2630283002/diff/40001/ui/file_manager/file_manager/foreground/js/thumbnail_loader.js File ui/file_manager/file_manager/foreground/js/thumbnail_loader.js (right): https://codereview.chromium.org/2630283002/diff/40001/ui/file_manager/file_manager/foreground/js/thumbnail_loader.js#newcode546 ui/file_manager/file_manager/foreground/js/thumbnail_loader.js:546: if (this.loaderType_ === ThumbnailLoader.LoaderType.IMAGE) On 2017/01/16 11:58:09, oka wrote: ...
3 years, 11 months ago (2017-01-16 12:13:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2630283002/60001
3 years, 11 months ago (2017-01-16 12:17:50 UTC) #11
oka
https://codereview.chromium.org/2630283002/diff/60001/ui/file_manager/file_manager/foreground/js/thumbnail_loader.js File ui/file_manager/file_manager/foreground/js/thumbnail_loader.js (right): https://codereview.chromium.org/2630283002/diff/60001/ui/file_manager/file_manager/foreground/js/thumbnail_loader.js#newcode329 ui/file_manager/file_manager/foreground/js/thumbnail_loader.js:329: * @param {number} width width of the original image ...
3 years, 11 months ago (2017-01-16 12:30:55 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/b1a8ea6390809eb8e166631a05eaf97406baf6ca
3 years, 11 months ago (2017-01-16 12:43:59 UTC) #15
yamaguchi
3 years, 11 months ago (2017-01-18 07:50:13 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2640743002/ by yamaguchi@chromium.org.

The reason for reverting is: crbug.com/682139.

Powered by Google App Engine
This is Rietveld 408576698