Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2640723002: [ES6 modules] Implement https://html.spec.whatwg.org/#resolve-a-module-specifier (Closed)

Created:
3 years, 11 months ago by kouhei (in TOK)
Modified:
3 years, 11 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : set upstream #

Patch Set 3 : include #

Total comments: 4

Patch Set 4 : absoluteURL #

Total comments: 6

Patch Set 5 : yhirano review2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -0 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Modulator.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Modulator.cpp View 1 2 3 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/ModulatorTest.cpp View 1 2 3 4 1 chunk +73 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (21 generated)
kouhei (in TOK)
3 years, 11 months ago (2017-01-18 06:57:55 UTC) #2
kouhei (in TOK)
PTAL
3 years, 11 months ago (2017-01-18 10:56:38 UTC) #11
domenic
Spec implementation and tests lgtm; I'll let others comment on the KURL usage (e.g. is ...
3 years, 11 months ago (2017-01-18 19:04:49 UTC) #12
yhirano
https://codereview.chromium.org/2640723002/diff/40001/third_party/WebKit/Source/core/dom/Modulator.cpp File third_party/WebKit/Source/core/dom/Modulator.cpp (right): https://codereview.chromium.org/2640723002/diff/40001/third_party/WebKit/Source/core/dom/Modulator.cpp#newcode38 third_party/WebKit/Source/core/dom/Modulator.cpp:38: KURL relativeURL(baseURL, moduleRequest); Should this be named as |absoluteURL|? ...
3 years, 11 months ago (2017-01-19 02:05:44 UTC) #13
kouhei (in TOK)
PTAL https://codereview.chromium.org/2640723002/diff/40001/third_party/WebKit/Source/core/dom/Modulator.cpp File third_party/WebKit/Source/core/dom/Modulator.cpp (right): https://codereview.chromium.org/2640723002/diff/40001/third_party/WebKit/Source/core/dom/Modulator.cpp#newcode38 third_party/WebKit/Source/core/dom/Modulator.cpp:38: KURL relativeURL(baseURL, moduleRequest); On 2017/01/19 02:05:44, yhirano wrote: ...
3 years, 11 months ago (2017-01-19 02:20:43 UTC) #14
yhirano
https://codereview.chromium.org/2640723002/diff/60001/third_party/WebKit/Source/core/dom/ModulatorTest.cpp File third_party/WebKit/Source/core/dom/ModulatorTest.cpp (right): https://codereview.chromium.org/2640723002/diff/60001/third_party/WebKit/Source/core/dom/ModulatorTest.cpp#newcode26 third_party/WebKit/Source/core/dom/ModulatorTest.cpp:26: EXPECT_STREQ("http://example.com/pears.mjs", You can compare strings, e.g, EXPECT_EQ("http://example.com/pears.mjs", resolved.elidedString()); https://codereview.chromium.org/2640723002/diff/60001/third_party/WebKit/Source/core/dom/ModulatorTest.cpp#newcode27 ...
3 years, 11 months ago (2017-01-19 03:53:53 UTC) #19
kouhei (in TOK)
https://codereview.chromium.org/2640723002/diff/60001/third_party/WebKit/Source/core/dom/ModulatorTest.cpp File third_party/WebKit/Source/core/dom/ModulatorTest.cpp (right): https://codereview.chromium.org/2640723002/diff/60001/third_party/WebKit/Source/core/dom/ModulatorTest.cpp#newcode26 third_party/WebKit/Source/core/dom/ModulatorTest.cpp:26: EXPECT_STREQ("http://example.com/pears.mjs", On 2017/01/19 03:53:53, yhirano wrote: > You can ...
3 years, 11 months ago (2017-01-19 04:07:01 UTC) #21
yhirano
lgtm
3 years, 11 months ago (2017-01-19 04:08:54 UTC) #23
dominicc (has gone to gerrit)
lgtm
3 years, 11 months ago (2017-01-19 05:10:52 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640723002/80001
3 years, 11 months ago (2017-01-19 08:47:03 UTC) #29
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 08:51:10 UTC) #32
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/605bc2f64983eba6b1f3d7a6b6e2...

Powered by Google App Engine
This is Rietveld 408576698