Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2640713002: Standardize ECursor enum value names (Closed)

Created:
3 years, 11 months ago by amoylan
Modified:
3 years, 11 months ago
Reviewers:
keishi, napper, sashab
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, dtapuska+blinkwatch_chromium.org, kinuko+watch, ktyliu, Navid Zolghadr, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Standardize ECursor enum value names This includes two updates to value names in the ECursor enum that are required in preparation for this enum to be automatically generated in future: * Use k-prefix * Rename Cross -> Crosshair BUG=628043 Review-Url: https://codereview.chromium.org/2640713002 Cr-Commit-Position: refs/heads/master@{#444981} Committed: https://chromium.googlesource.com/chromium/src/+/b5695963741c4d95f87de36114abe737b5bdb0a1

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -151 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 2 chunks +73 lines, -73 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 chunk +37 lines, -37 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 1 chunk +36 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 27 (17 generated)
amoylan
3 years, 11 months ago (2017-01-19 06:03:21 UTC) #7
napper
lgtm
3 years, 11 months ago (2017-01-19 23:34:16 UTC) #8
amoylan
Thanks Jon +sashab
3 years, 11 months ago (2017-01-19 23:35:12 UTC) #10
sashab
lgtm
3 years, 11 months ago (2017-01-20 02:37:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640713002/20001
3 years, 11 months ago (2017-01-20 02:44:52 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/346085)
3 years, 11 months ago (2017-01-20 02:54:03 UTC) #18
amoylan
+keishi for OWNERS on third_party/WebKit/Source/web/WebViewImpl.cpp
3 years, 11 months ago (2017-01-20 03:04:24 UTC) #21
keishi
On 2017/01/20 03:04:24, amoylan wrote: > +keishi for OWNERS on third_party/WebKit/Source/web/WebViewImpl.cpp WebViewImpl.cpp LGTM
3 years, 11 months ago (2017-01-20 03:10:46 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640713002/20001
3 years, 11 months ago (2017-01-20 03:15:51 UTC) #24
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 04:19:39 UTC) #27
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b5695963741c4d95f87de36114ab...

Powered by Google App Engine
This is Rietveld 408576698