Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2640673002: (WIP) Use generator to generate externs for chrome.fileManagerPrivate API.

Created:
3 years, 11 months ago by fukino
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews, vitalyp+closure_chromium.org, rginda+watch_chromium.org, jlklein+watch-closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

(WIP) Use generator to generate externs for chrome.fileManagerPrivate API. BUG=613096 TEST=run third_party/closure_compiler/run_compiler CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Patch Set 2 : Compile passes #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1425 lines, -328 lines) Patch
M third_party/closure_compiler/externs/chrome_extensions.js View 1 1 chunk +635 lines, -0 lines 1 comment Download
M third_party/closure_compiler/externs/compiled_resources2.gyp View 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/closure_compiler/externs/file_manager_private.js View 1 10 chunks +610 lines, -260 lines 0 comments Download
A third_party/closure_compiler/externs/manifest_types.js View 1 chunk +85 lines, -0 lines 0 comments Download
M ui/file_manager/audio_player/js/audio_player.js View 1 1 chunk +8 lines, -4 lines 0 comments Download
M ui/file_manager/audio_player/js/compiled_resources.gyp View 1 2 chunks +2 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/background/js/compiled_resources.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager/background/js/device_handler.js View 1 3 chunks +4 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/background/js/drive_sync_handler.js View 1 4 chunks +5 lines, -4 lines 0 comments Download
M ui/file_manager/file_manager/background/js/import_history.js View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/background/js/launcher_search.js View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/background/js/media_import_handler.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/background/js/media_scanner.js View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/background/js/volume_manager_impl.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/background/js/volume_manager_util.js View 1 2 chunks +3 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/compiled_resources.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/directory_contents.js View 1 3 chunks +2 lines, -14 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/directory_model.js View 1 1 chunk +3 lines, -6 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager_commands.js View 1 7 chunks +14 lines, -7 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_transfer_controller.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/import_controller.js View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/compiled_resources2.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/quick_view_controller.js View 1 4 chunks +6 lines, -5 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/search_controller.js View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/gear_menu.js View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ui/file_manager/gallery/js/compiled_resources.gyp View 1 2 chunks +2 lines, -0 lines 0 comments Download
M ui/file_manager/gallery/js/entry_list_watcher.js View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/gallery/js/gallery.js View 1 1 chunk +8 lines, -4 lines 0 comments Download
M ui/file_manager/gallery/js/slide_mode.js View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/image_loader/compiled_resources.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/video_player/js/compiled_resources.gyp View 1 2 chunks +2 lines, -0 lines 0 comments Download
M ui/file_manager/video_player/js/video_player.js View 1 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
fukino
3 years, 11 months ago (2017-01-18 03:01:38 UTC) #3 
https://codereview.chromium.org/2640673002/diff/20001/third_party/closure_com...
File third_party/closure_compiler/externs/chrome_extensions.js (right):

https://codereview.chromium.org/2640673002/diff/20001/third_party/closure_com...
third_party/closure_compiler/externs/chrome_extensions.js:10648:
chrome.fileSystemProvider = {};
Adding chrome.fileSystemPrivider API needs to be done in upstream extern file
first.

Powered by Google App Engine
This is Rietveld 408576698