Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: ui/file_manager/file_manager/foreground/js/file_manager_commands.js

Issue 2640673002: (WIP) Use generator to generate externs for chrome.fileManagerPrivate API.
Patch Set: Compile passes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/file_manager_commands.js
diff --git a/ui/file_manager/file_manager/foreground/js/file_manager_commands.js b/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
index 4a75d36768c361f455307bc448726f1196e9a6e6..a2228be5826d6fe358af4ff573a86ebccbe00ac5 100644
--- a/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
+++ b/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
@@ -1326,7 +1326,8 @@ CommandHandler.COMMANDS_['zoom-in'] = /** @type {Command} */ ({
* @param {!FileManager} fileManager FileManager to use.
*/
execute: function(event, fileManager) {
- chrome.fileManagerPrivate.zoom('in');
+ chrome.fileManagerPrivate.zoom(
+ chrome.fileManagerPrivate.ZoomOperationType.IN);
},
canExecute: CommandUtil.canExecuteAlways
});
@@ -1341,7 +1342,8 @@ CommandHandler.COMMANDS_['zoom-out'] = /** @type {Command} */ ({
* @param {!FileManager} fileManager FileManager to use.
*/
execute: function(event, fileManager) {
- chrome.fileManagerPrivate.zoom('out');
+ chrome.fileManagerPrivate.zoom(
+ chrome.fileManagerPrivate.ZoomOperationType.OUT);
},
canExecute: CommandUtil.canExecuteAlways
});
@@ -1356,7 +1358,8 @@ CommandHandler.COMMANDS_['zoom-reset'] = /** @type {Command} */ ({
* @param {!FileManager} fileManager FileManager to use.
*/
execute: function(event, fileManager) {
- chrome.fileManagerPrivate.zoom('reset');
+ chrome.fileManagerPrivate.zoom(
+ chrome.fileManagerPrivate.ZoomOperationType.RESET);
},
canExecute: CommandUtil.canExecuteAlways
});
@@ -1419,7 +1422,8 @@ CommandHandler.COMMANDS_['inspect-normal'] = /** @type {Command} */ ({
* @param {!FileManager} fileManager FileManager to use.
*/
execute: function(event, fileManager) {
- chrome.fileManagerPrivate.openInspector('normal');
+ chrome.fileManagerPrivate.openInspector(
+ chrome.fileManagerPrivate.InspectionType.NORMAL);
},
canExecute: CommandUtil.canExecuteAlways
});
@@ -1434,7 +1438,8 @@ CommandHandler.COMMANDS_['inspect-console'] = /** @type {Command} */ ({
* @param {!FileManager} fileManager FileManager to use.
*/
execute: function(event, fileManager) {
- chrome.fileManagerPrivate.openInspector('console');
+ chrome.fileManagerPrivate.openInspector(
+ chrome.fileManagerPrivate.InspectionType.CONSOLE);
},
canExecute: CommandUtil.canExecuteAlways
});
@@ -1449,7 +1454,8 @@ CommandHandler.COMMANDS_['inspect-element'] = /** @type {Command} */ ({
* @param {!FileManager} fileManager FileManager to use.
*/
execute: function(event, fileManager) {
- chrome.fileManagerPrivate.openInspector('element');
+ chrome.fileManagerPrivate.openInspector(
+ chrome.fileManagerPrivate.InspectionType.ELEMENT);
},
canExecute: CommandUtil.canExecuteAlways
});
@@ -1464,7 +1470,8 @@ CommandHandler.COMMANDS_['inspect-background'] = /** @type {Command} */ ({
* @param {!FileManager} fileManager FileManager to use.
*/
execute: function(event, fileManager) {
- chrome.fileManagerPrivate.openInspector('background');
+ chrome.fileManagerPrivate.openInspector(
+ chrome.fileManagerPrivate.InspectionType.BACKGROUND);
},
canExecute: CommandUtil.canExecuteAlways
});

Powered by Google App Engine
This is Rietveld 408576698