Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 2640643002: Files app: Use relative paths to specify compile dependencies in the package. (Closed)

Created:
3 years, 11 months ago by fukino
Modified:
3 years, 11 months ago
Reviewers:
oka, Dan Beam
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, fukino+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files app: Use relative paths to specify compile dependencies in the package. BUG=636289 TEST=run third_party/closure_compiler/run_compiler CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2640643002 Cr-Commit-Position: refs/heads/master@{#444290} Committed: https://chromium.googlesource.com/chromium/src/+/f128c6d887c28cdf75d90413cddf7791c516493c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M ui/file_manager/file_manager/common/js/compiled_resources2.gyp View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/compiled_resources2.gyp View 6 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
fukino
PTAL
3 years, 11 months ago (2017-01-18 00:45:21 UTC) #3
Dan Beam
lgtm
3 years, 11 months ago (2017-01-18 01:49:14 UTC) #5
oka
lgtm
3 years, 11 months ago (2017-01-18 05:42:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640643002/1
3 years, 11 months ago (2017-01-18 05:52:00 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 05:56:10 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f128c6d887c28cdf75d90413cddf...

Powered by Google App Engine
This is Rietveld 408576698