Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2640633002: Convert PlatformVerificationDialog to use the new navigation callbacks. (Closed)

Created:
3 years, 11 months ago by jam
Modified:
3 years, 11 months ago
Reviewers:
oshima
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org, dkrahn+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert PlatformVerificationDialog to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2640633002 Cr-Commit-Position: refs/heads/master@{#444476} Committed: https://chromium.googlesource.com/chromium/src/+/608ff43a3cbf5527c5197741409df6b1cb58a4fb

Patch Set 1 #

Patch Set 2 : closer to original #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M chrome/browser/chromeos/attestation/platform_verification_dialog.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/attestation/platform_verification_dialog.cc View 1 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
jam
3 years, 11 months ago (2017-01-18 04:23:02 UTC) #7
jam
->oshima since the existing owners are all off chrome now
3 years, 11 months ago (2017-01-18 20:20:12 UTC) #9
oshima
lgtm
3 years, 11 months ago (2017-01-18 20:27:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640633002/20001
3 years, 11 months ago (2017-01-18 20:59:09 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 21:05:52 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/608ff43a3cbf5527c5197741409d...

Powered by Google App Engine
This is Rietveld 408576698