Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2640623002: [heap] VerifyPointersVisitor should check that non-HeapObjects are Smis (Closed)

Created:
3 years, 11 months ago by adamk
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] VerifyPointersVisitor should check that non-HeapObjects are Smis This brings VerifyPointersVisitor into line with Object::VerifyPointer. R=hpayer@chromium.org BUG=v8:5854 Review-Url: https://codereview.chromium.org/2640623002 Cr-Commit-Position: refs/heads/master@{#42471} Committed: https://chromium.googlesource.com/v8/v8/+/656880510bdb752595d1b903797eeb675d1a7b8d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/heap/heap-inl.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
adamk
3 years, 11 months ago (2017-01-18 00:06:42 UTC) #1
Hannes Payer (out of office)
lgtm
3 years, 11 months ago (2017-01-18 12:12:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640623002/1
3 years, 11 months ago (2017-01-18 17:35:52 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 17:37:53 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/656880510bdb752595d1b903797eeb675d1...

Powered by Google App Engine
This is Rietveld 408576698