cc: Fix a hang in image controller unittests by release task lock.

cc: Fix a hang in image controller unittests by release task lock.

This patch ensures that when we run tasks in our TestWorkerThread, we
release the lock before running the task. If we don't release the lock,
then the task itself can go and acquire a lock in the image controller.

However, if we're currently in QueueImageTask in the image controller
(ie we have that lock), and we're posting a task, we try to acquire
the task runner lock.

All in all, this ends up in a cyclical deadlock:
- thread 1 has A, wants B.
- thread 2 has B, wants A.

This patch ensures that thread 1 above, releases A before running a
task that wants B.

R=enne@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2640553003
Cr-Commit-Position: refs/heads/master@{#444237}
Committed: https://chromium.googlesource.com/chromium/src/+/7330b6a4d60bb3c17e4931ba0deed4c253cb5ee0

[vmpstr, 2017-01-18 01:21:45]

Description was changed from

==========
cc: Fix a hang in image controller unittests by release task lock.

This patch ensures that when we run tasks in our TestWorkerThread, we
release the lock before running the task. If we don't release the lock,
then the task itself can go and acquire a lock in the image controller.

However, if we're currently in QueueImageTask in the image controller
(ie we have that lock), and we're posting a task, we try to acquire
the task runner lock.

All in all, this ends up in a cyclical deadlock:
- thread 1 has A, wants B.
- thread 2 has B, wants A.

This patch ensures that thread 1 above, releases A before running a
task that wants B.

R=enne@chromium.org
==========

to

==========
cc: Fix a hang in image controller unittests by release task lock.

This patch ensures that when we run tasks in our TestWorkerThread, we
release the lock before running the task. If we don't release the lock,
then the task itself can go and acquire a lock in the image controller.

However, if we're currently in QueueImageTask in the image controller
(ie we have that lock), and we're posting a task, we try to acquire
the task runner lock.

All in all, this ends up in a cyclical deadlock:
- thread 1 has A, wants B.
- thread 2 has B, wants A.

This patch ensures that thread 1 above, releases A before running a
task that wants B.

R=enne@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[vmpstr, 2017-01-18 01:22:15]

Please take a look.

[enne (OOO), 2017-01-18 01:29:38]

lgtm

[vmpstr, 2017-01-18 01:35:42]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2017-01-18 01:36:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 01:53:07]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484703342197220, "parent_rev":
"e13041dd9cd61c8ed5bb920a61d4fc2ec4e47df2", "commit_rev":
"7330b6a4d60bb3c17e4931ba0deed4c253cb5ee0"}

[commit-bot: I haz the power, 2017-01-18 01:53:41]

Description was changed from

==========
cc: Fix a hang in image controller unittests by release task lock.

This patch ensures that when we run tasks in our TestWorkerThread, we
release the lock before running the task. If we don't release the lock,
then the task itself can go and acquire a lock in the image controller.

However, if we're currently in QueueImageTask in the image controller
(ie we have that lock), and we're posting a task, we try to acquire
the task runner lock.

All in all, this ends up in a cyclical deadlock:
- thread 1 has A, wants B.
- thread 2 has B, wants A.

This patch ensures that thread 1 above, releases A before running a
task that wants B.

R=enne@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Fix a hang in image controller unittests by release task lock.

This patch ensures that when we run tasks in our TestWorkerThread, we
release the lock before running the task. If we don't release the lock,
then the task itself can go and acquire a lock in the image controller.

However, if we're currently in QueueImageTask in the image controller
(ie we have that lock), and we're posting a task, we try to acquire
the task runner lock.

All in all, this ends up in a cyclical deadlock:
- thread 1 has A, wants B.
- thread 2 has B, wants A.

This patch ensures that thread 1 above, releases A before running a
task that wants B.

R=enne@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2640553003
Cr-Commit-Position: refs/heads/master@{#444237}
Committed:
https://chromium.googlesource.com/chromium/src/+/7330b6a4d60bb3c17e4931ba0dee...
==========

[commit-bot: I haz the power, 2017-01-18 01:53:42]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7330b6a4d60bb3c17e4931ba0dee...