Disable next compatibility mode for ChromeVox on dev channel

Disable next compatibility mode for ChromeVox on dev channel

TEST=manual

Review-Url: https://codereview.chromium.org/2640503002
Cr-Commit-Position: refs/heads/master@{#444460}
Committed: https://chromium.googlesource.com/chromium/src/+/9f6feb599e11f479f540ddf766d3187797b21813

[David Tseng, 2017-01-17 17:48:14]

Description was changed from

==========
Disable next compatibility mode for ChromeVox on dev channel

- adds a utility class to fetch the current Chrome channel. Useful for setting
up feature work that can be targeted for a specific Chrome OS channel.
- ties next compat mode to non-dev channel releases.

Sample csv format:
os,channel,current_version,previous_version,current_reldate,previous_reldate,branch_base_commit,branch_base_position,branch_commit,true_branch,v8_version
win,canary_asan,57.0.2984.1,57.0.2983.1,01/17/17,01/16/17,a2377c097a1fa051f90f9c02d96d010073fcb701,443964,ae6099686d0aed11def1a2410187564e7932d43e,2984,5.7.475.0
win,canary,57.0.2984.0,57.0.2983.0,01/17/17,01/16/17,12b95dafd954e5814efefb1ffd9ec4b09976569c,443964,12b95dafd954e5814efefb1ffd9ec4b09976569c,master,5.7.475.0
...
linux,stable,55.0.2883.87,52.0.2743.116,12/12/16,08/03/16,614d31daee2f61b0180df403a8ad43f20b9f6dd7,423768,12203fa1bfc7f10c98bcbceaa11161fd1d1c17f8,2883,5.5.372.32
cros,dev,57.0.2970.0,57.0.2951.0,01/05/17,12/15/16,32378f5102b5480aec33ae1dee45a7e0a15bd002,441083,32378f5102b5480aec33ae1dee45a7e0a15bd002,master,5.7.376.0
android,canary,57.0.2984.0,57.0.2983.0,01/17/17,01/16/17,12b95dafd954e5814efefb1ffd9ec4b09976569c,443964,12b95dafd954e5814efefb1ffd9ec4b09976569c,master,5.7.475.0
...
ios,stable,55.0.2883.79,54.0.2840.91,12/06/16,11/07/16,N/A,N/A,N/A,N/A,N/A

TEST=observe Version.currentChannel is dev and that the fetched version is
currently 57.

Support focus highlight in Android window

BUG=b/31788292
TEST=Enable focus highlight in Chrome accessibility settings, and see it
     works in Android window.

patch from issue 2559663002 at patchset 140001
(http://crrev.com/2559663002#ps140001)
==========

to

==========
Disable next compatibility mode for ChromeVox on dev channel

- adds a utility class to fetch the current Chrome channel. Useful for setting
up feature work that can be targeted for a specific Chrome OS channel.
- ties next compat mode to non-dev channel releases.

Sample csv format:
os,channel,current_version,previous_version,current_reldate,previous_reldate,branch_base_commit,branch_base_position,branch_commit,true_branch,v8_version
win,canary_asan,57.0.2984.1,57.0.2983.1,01/17/17,01/16/17,a2377c097a1fa051f90f9c02d96d010073fcb701,443964,ae6099686d0aed11def1a2410187564e7932d43e,2984,5.7.475.0
win,canary,57.0.2984.0,57.0.2983.0,01/17/17,01/16/17,12b95dafd954e5814efefb1ffd9ec4b09976569c,443964,12b95dafd954e5814efefb1ffd9ec4b09976569c,master,5.7.475.0
...
linux,stable,55.0.2883.87,52.0.2743.116,12/12/16,08/03/16,614d31daee2f61b0180df403a8ad43f20b9f6dd7,423768,12203fa1bfc7f10c98bcbceaa11161fd1d1c17f8,2883,5.5.372.32
cros,dev,57.0.2970.0,57.0.2951.0,01/05/17,12/15/16,32378f5102b5480aec33ae1dee45a7e0a15bd002,441083,32378f5102b5480aec33ae1dee45a7e0a15bd002,master,5.7.376.0
android,canary,57.0.2984.0,57.0.2983.0,01/17/17,01/16/17,12b95dafd954e5814efefb1ffd9ec4b09976569c,443964,12b95dafd954e5814efefb1ffd9ec4b09976569c,master,5.7.475.0
...
ios,stable,55.0.2883.79,54.0.2840.91,12/06/16,11/07/16,N/A,N/A,N/A,N/A,N/A

TEST=observe Version.currentChannel is dev and that the fetched version is
currently 57.

Support focus highlight in Android window

BUG=b/31788292
TEST=Enable focus highlight in Chrome accessibility settings, and see it
     works in Android window.

patch from issue 2559663002 at patchset 140001
(http://crrev.com/2559663002#ps140001)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2017-01-17 17:48:39]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[David Tseng, 2017-01-17 18:00:34]

Patchset #1 (id:1) has been deleted

[David Tseng, 2017-01-17 18:06:50]

Description was changed from

==========
Disable next compatibility mode for ChromeVox on dev channel

- adds a utility class to fetch the current Chrome channel. Useful for setting
up feature work that can be targeted for a specific Chrome OS channel.
- ties next compat mode to non-dev channel releases.

Sample csv format:
os,channel,current_version,previous_version,current_reldate,previous_reldate,branch_base_commit,branch_base_position,branch_commit,true_branch,v8_version
win,canary_asan,57.0.2984.1,57.0.2983.1,01/17/17,01/16/17,a2377c097a1fa051f90f9c02d96d010073fcb701,443964,ae6099686d0aed11def1a2410187564e7932d43e,2984,5.7.475.0
win,canary,57.0.2984.0,57.0.2983.0,01/17/17,01/16/17,12b95dafd954e5814efefb1ffd9ec4b09976569c,443964,12b95dafd954e5814efefb1ffd9ec4b09976569c,master,5.7.475.0
...
linux,stable,55.0.2883.87,52.0.2743.116,12/12/16,08/03/16,614d31daee2f61b0180df403a8ad43f20b9f6dd7,423768,12203fa1bfc7f10c98bcbceaa11161fd1d1c17f8,2883,5.5.372.32
cros,dev,57.0.2970.0,57.0.2951.0,01/05/17,12/15/16,32378f5102b5480aec33ae1dee45a7e0a15bd002,441083,32378f5102b5480aec33ae1dee45a7e0a15bd002,master,5.7.376.0
android,canary,57.0.2984.0,57.0.2983.0,01/17/17,01/16/17,12b95dafd954e5814efefb1ffd9ec4b09976569c,443964,12b95dafd954e5814efefb1ffd9ec4b09976569c,master,5.7.475.0
...
ios,stable,55.0.2883.79,54.0.2840.91,12/06/16,11/07/16,N/A,N/A,N/A,N/A,N/A

TEST=observe Version.currentChannel is dev and that the fetched version is
currently 57.

Support focus highlight in Android window

BUG=b/31788292
TEST=Enable focus highlight in Chrome accessibility settings, and see it
     works in Android window.

patch from issue 2559663002 at patchset 140001
(http://crrev.com/2559663002#ps140001)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Disable next compatibility mode for ChromeVox on dev channel

- adds a utility class to fetch the current Chrome channel. Useful for setting
up feature work that can be targeted for a specific Chrome OS channel.
- ties next compat mode to non-dev channel releases.

Sample csv format:
os,channel,current_version,previous_version,current_reldate,previous_reldate,branch_base_commit,branch_base_position,branch_commit,true_branch,v8_version
win,canary_asan,57.0.2984.1,57.0.2983.1,01/17/17,01/16/17,a2377c097a1fa051f90f9c02d96d010073fcb701,443964,ae6099686d0aed11def1a2410187564e7932d43e,2984,5.7.475.0
win,canary,57.0.2984.0,57.0.2983.0,01/17/17,01/16/17,12b95dafd954e5814efefb1ffd9ec4b09976569c,443964,12b95dafd954e5814efefb1ffd9ec4b09976569c,master,5.7.475.0
...
linux,stable,55.0.2883.87,52.0.2743.116,12/12/16,08/03/16,614d31daee2f61b0180df403a8ad43f20b9f6dd7,423768,12203fa1bfc7f10c98bcbceaa11161fd1d1c17f8,2883,5.5.372.32
cros,dev,57.0.2970.0,57.0.2951.0,01/05/17,12/15/16,32378f5102b5480aec33ae1dee45a7e0a15bd002,441083,32378f5102b5480aec33ae1dee45a7e0a15bd002,master,5.7.376.0
android,canary,57.0.2984.0,57.0.2983.0,01/17/17,01/16/17,12b95dafd954e5814efefb1ffd9ec4b09976569c,443964,12b95dafd954e5814efefb1ffd9ec4b09976569c,master,5.7.475.0
...
ios,stable,55.0.2883.79,54.0.2840.91,12/06/16,11/07/16,N/A,N/A,N/A,N/A,N/A

TEST=observe Version.currentChannel is dev and that the fetched version is
currently 57.
==========

[dmazzoni, 2017-01-18 16:32:11]

There are periods of time when multiple channels have the
same major version number.

I think the right way to do it is to call chrome::GetChannelString()
in the browser process.

If you want a quick and dirty solution without the boilerplate
of an extension function, maybe the channel could be an
attribute of the root of the desktop tree or something like
that.

Making a call to omahaproxy is probably a bad idea for
other reasons too, like privacy.

[David Tseng, 2017-01-18 18:37:14]

Description was changed from

==========
Disable next compatibility mode for ChromeVox on dev channel

- adds a utility class to fetch the current Chrome channel. Useful for setting
up feature work that can be targeted for a specific Chrome OS channel.
- ties next compat mode to non-dev channel releases.

Sample csv format:
os,channel,current_version,previous_version,current_reldate,previous_reldate,branch_base_commit,branch_base_position,branch_commit,true_branch,v8_version
win,canary_asan,57.0.2984.1,57.0.2983.1,01/17/17,01/16/17,a2377c097a1fa051f90f9c02d96d010073fcb701,443964,ae6099686d0aed11def1a2410187564e7932d43e,2984,5.7.475.0
win,canary,57.0.2984.0,57.0.2983.0,01/17/17,01/16/17,12b95dafd954e5814efefb1ffd9ec4b09976569c,443964,12b95dafd954e5814efefb1ffd9ec4b09976569c,master,5.7.475.0
...
linux,stable,55.0.2883.87,52.0.2743.116,12/12/16,08/03/16,614d31daee2f61b0180df403a8ad43f20b9f6dd7,423768,12203fa1bfc7f10c98bcbceaa11161fd1d1c17f8,2883,5.5.372.32
cros,dev,57.0.2970.0,57.0.2951.0,01/05/17,12/15/16,32378f5102b5480aec33ae1dee45a7e0a15bd002,441083,32378f5102b5480aec33ae1dee45a7e0a15bd002,master,5.7.376.0
android,canary,57.0.2984.0,57.0.2983.0,01/17/17,01/16/17,12b95dafd954e5814efefb1ffd9ec4b09976569c,443964,12b95dafd954e5814efefb1ffd9ec4b09976569c,master,5.7.475.0
...
ios,stable,55.0.2883.79,54.0.2840.91,12/06/16,11/07/16,N/A,N/A,N/A,N/A,N/A

TEST=observe Version.currentChannel is dev and that the fetched version is
currently 57.
==========

to

==========
Disable next compatibility mode for ChromeVox on dev channel

- adds a utility class to fetch the current Chrome channel. Useful for setting
up feature work that can be targeted for a specific Chrome OS channel.
- ties next compat mode to non-dev channel releases.

Sample csv format:
os,channel,current_version,previous_version,current_reldate,previous_reldate,branch_base_commit,branch_base_position,branch_commit,true_branch,v8_version
win,canary_asan,57.0.2984.1,57.0.2983.1,01/17/17,01/16/17,a2377c097a1fa051f90f9c02d96d010073fcb701,443964,ae6099686d0aed11def1a2410187564e7932d43e,2984,5.7.475.0
win,canary,57.0.2984.0,57.0.2983.0,01/17/17,01/16/17,12b95dafd954e5814efefb1ffd9ec4b09976569c,443964,12b95dafd954e5814efefb1ffd9ec4b09976569c,master,5.7.475.0
...
linux,stable,55.0.2883.87,52.0.2743.116,12/12/16,08/03/16,614d31daee2f61b0180df403a8ad43f20b9f6dd7,423768,12203fa1bfc7f10c98bcbceaa11161fd1d1c17f8,2883,5.5.372.32
cros,dev,57.0.2970.0,57.0.2951.0,01/05/17,12/15/16,32378f5102b5480aec33ae1dee45a7e0a15bd002,441083,32378f5102b5480aec33ae1dee45a7e0a15bd002,master,5.7.376.0
android,canary,57.0.2984.0,57.0.2983.0,01/17/17,01/16/17,12b95dafd954e5814efefb1ffd9ec4b09976569c,443964,12b95dafd954e5814efefb1ffd9ec4b09976569c,master,5.7.475.0
...
ios,stable,55.0.2883.79,54.0.2840.91,12/06/16,11/07/16,N/A,N/A,N/A,N/A,N/A

TEST=observe Version.currentChannel is dev and that the fetched version is
currently 57.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2017-01-18 18:37:24]

dmazzoni@chromium.org writes:

> I think the right way to do it is to call chrome::GetChannelString()
> in the browser process.

Looked at that as well but didn't go that way because of the below.>

> If you want a quick and dirty solution without the boilerplate
> of an extension function, maybe the channel could be an
> attribute of the root of the desktop tree or something like
> that.
>

Added though still boiler plate but no approvals beyond yours.

> Making a call to omahaproxy is probably a bad idea for
> other reasons too, like privacy.

We own that appengine instance, so not really sure that's a
concern. Originally, thought it would be useful for all platforms
depending on which way we take ChromeVox (desktop doesn't exist on Mac)
and ChromeVox version differs from Chrome version (which has been the
single biggest pain point for ChromeVox webstore extensions).
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[David Tseng, 2017-01-18 18:37:41]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 18:38:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[David Tseng, 2017-01-18 18:41:14]

Description was changed from

==========
Disable next compatibility mode for ChromeVox on dev channel

- adds a utility class to fetch the current Chrome channel. Useful for setting
up feature work that can be targeted for a specific Chrome OS channel.
- ties next compat mode to non-dev channel releases.

Sample csv format:
os,channel,current_version,previous_version,current_reldate,previous_reldate,branch_base_commit,branch_base_position,branch_commit,true_branch,v8_version
win,canary_asan,57.0.2984.1,57.0.2983.1,01/17/17,01/16/17,a2377c097a1fa051f90f9c02d96d010073fcb701,443964,ae6099686d0aed11def1a2410187564e7932d43e,2984,5.7.475.0
win,canary,57.0.2984.0,57.0.2983.0,01/17/17,01/16/17,12b95dafd954e5814efefb1ffd9ec4b09976569c,443964,12b95dafd954e5814efefb1ffd9ec4b09976569c,master,5.7.475.0
...
linux,stable,55.0.2883.87,52.0.2743.116,12/12/16,08/03/16,614d31daee2f61b0180df403a8ad43f20b9f6dd7,423768,12203fa1bfc7f10c98bcbceaa11161fd1d1c17f8,2883,5.5.372.32
cros,dev,57.0.2970.0,57.0.2951.0,01/05/17,12/15/16,32378f5102b5480aec33ae1dee45a7e0a15bd002,441083,32378f5102b5480aec33ae1dee45a7e0a15bd002,master,5.7.376.0
android,canary,57.0.2984.0,57.0.2983.0,01/17/17,01/16/17,12b95dafd954e5814efefb1ffd9ec4b09976569c,443964,12b95dafd954e5814efefb1ffd9ec4b09976569c,master,5.7.475.0
...
ios,stable,55.0.2883.79,54.0.2840.91,12/06/16,11/07/16,N/A,N/A,N/A,N/A,N/A

TEST=observe Version.currentChannel is dev and that the fetched version is
currently 57.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Disable next compatibility mode for ChromeVox on dev channel

TEST=manual
==========

[dmazzoni, 2017-01-18 18:48:19]

lgtm

[commit-bot: I haz the power, 2017-01-18 19:38:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 19:38:37]

Dry run: This issue passed the CQ dry run.

[David Tseng, 2017-01-18 20:21:15]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2017-01-18 20:21:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 20:26:56]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484770875794140,
"parent_rev": "9b27859765e32d5de88395f802d9a861e2feac96", "commit_rev":
"9f6feb599e11f479f540ddf766d3187797b21813"}

[commit-bot: I haz the power, 2017-01-18 20:27:30]

Description was changed from

==========
Disable next compatibility mode for ChromeVox on dev channel

TEST=manual
==========

to

==========
Disable next compatibility mode for ChromeVox on dev channel

TEST=manual

Review-Url: https://codereview.chromium.org/2640503002
Cr-Commit-Position: refs/heads/master@{#444460}
Committed:
https://chromium.googlesource.com/chromium/src/+/9f6feb599e11f479f540ddf766d3...
==========

[commit-bot: I haz the power, 2017-01-18 20:27:32]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9f6feb599e11f479f540ddf766d3...