content/browser/web_contents/web_contents_view_aura_browsertest.cc - Issue 2640473003: Convert tests to use the non-deprecated WebContentsObserver navigation methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_view_aura_browsertest.cc

Issue 2640473003: Convert tests to use the non-deprecated WebContentsObserver navigation methods. (Closed)

Patch Set: split off SearchTabHelper test Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_view_aura_browsertest.cc

diff --git a/content/browser/web_contents/web_contents_view_aura_browsertest.cc b/content/browser/web_contents/web_contents_view_aura_browsertest.cc

index 88785e40412260eace366f13d59ea528f1d17865..1c2362cefe0111f98327f6ef8b45ec9957a8dde9 100644

--- a/content/browser/web_contents/web_contents_view_aura_browsertest.cc

+++ b/content/browser/web_contents/web_contents_view_aura_browsertest.cc

@@ -178,8 +178,7 @@ class NavigationWatcher : public WebContentsObserver {

private:

// Overridden from WebContentsObserver:

- void DidStartNavigationToPendingEntry(const GURL& validated_url,

- ReloadType reload_type) override {

+ void DidStartNavigation(NavigationHandle* navigation_handle) override {

clamy 2017/01/18 14:33:34 Note: the tests here could maybe use the TestNavig

jam 2017/01/18 16:35:21 Done.

navigated_ = true;

if (should_quit_loop_)

base::MessageLoop::current()->QuitWhenIdle();