Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2320)

Unified Diff: content/browser/web_contents/web_contents_impl_browsertest.cc

Issue 2640473003: Convert tests to use the non-deprecated WebContentsObserver navigation methods. (Closed)
Patch Set: split off SearchTabHelper test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl_browsertest.cc
diff --git a/content/browser/web_contents/web_contents_impl_browsertest.cc b/content/browser/web_contents/web_contents_impl_browsertest.cc
index 976b7fc74120b689ad5b42e8cff4a9b5c7a31ea5..6a6dae67a935098692bf8134a76f4b2e0f68f75d 100644
--- a/content/browser/web_contents/web_contents_impl_browsertest.cc
+++ b/content/browser/web_contents/web_contents_impl_browsertest.cc
@@ -158,9 +158,7 @@ class RenderViewSizeObserver : public WebContentsObserver {
rwhv_create_size_ = rvh->GetWidget()->GetView()->GetViewBounds().size();
}
- void DidStartProvisionalLoadForFrame(RenderFrameHost* render_frame_host,
- const GURL& url,
- bool is_error_page) override {
+ void DidStartNavigation(NavigationHandle* navigation_handle) override {
clamy 2017/01/18 14:33:34 Should we exclude same page navigation? They would
jam 2017/01/18 16:35:21 this is only used by a single test which doesn't n
clamy 2017/01/19 14:59:37 Acknowledged.
ResizeWebContentsView(shell_, wcv_new_size_, false);
}

Powered by Google App Engine
This is Rietveld 408576698