Convert tests to use the non-deprecated WebContentsObserver navigation methods.

content/browser/web_contents/web_contents_impl_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/macros.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "build/build_config.h"
 #include "content/browser/frame_host/navigation_entry_impl.h"
@@ skipping 140 matching lines @@
       : WebContentsObserver(shell->web_contents()),
         shell_(shell),
         wcv_new_size_(wcv_new_size) {
   }
 
   // WebContentsObserver:
   void RenderViewCreated(RenderViewHost* rvh) override {
     rwhv_create_size_ = rvh->GetWidget()->GetView()->GetViewBounds().size();
   }
 
-  void DidStartProvisionalLoadForFrame(RenderFrameHost* render_frame_host,
-                                       const GURL& url,
-                                       bool is_error_page) override {
+  void DidStartNavigation(NavigationHandle* navigation_handle) override {

[clamy, 2017/01/18 14:33:34]

Should we exclude same page navigation? They wouldn't have triggered
DidStartProvisionalLoadForFrame before.

[jam, 2017/01/18 16:35:21]

this is only used by a single test which doesn't need this extra check, so i
left it as simple as could be to make the test pass

[clamy, 2017/01/19 14:59:37]

Acknowledged.

     ResizeWebContentsView(shell_, wcv_new_size_, false);
   }
 
   gfx::Size rwhv_create_size() const { return rwhv_create_size_; }
 
  private:
   Shell* shell_;  // Weak ptr.
   gfx::Size wcv_new_size_;
   gfx::Size rwhv_create_size_;
 };
@@ skipping 1148 matching lines @@
   // Make sure the WebContents cleaned up the previous pending request. A new
   // request should be forwarded to the WebContentsDelegate.
   delegate.get()->request_to_lock_mouse_called_ = false;
   ASSERT_TRUE(ExecuteScript(shell(),
                             "window.domAutomationController.send(document.body."
                             "requestPointerLock());"));
   EXPECT_TRUE(delegate.get()->request_to_lock_mouse_called_);
 }
 
 }  // namespace content