Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: ios/showcase/suggestions/sc_suggestions_coordinator.mm

Issue 2640473002: Suggestions UI - favicon item (Closed)
Patch Set: Fix compilation Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/showcase/suggestions/sc_suggestions_coordinator.mm
diff --git a/ios/showcase/suggestions/sc_suggestions_coordinator.mm b/ios/showcase/suggestions/sc_suggestions_coordinator.mm
index 06c6feb1c4692016878f56078b222c4355f6d4d9..79eaf32a8f704888b12e830611b13ca5ff192498 100644
--- a/ios/showcase/suggestions/sc_suggestions_coordinator.mm
+++ b/ios/showcase/suggestions/sc_suggestions_coordinator.mm
@@ -59,4 +59,8 @@
openFirstPageOfReadingList];
}
+- (void)openFaviconAtIndex:(NSInteger)index {
+ [static_cast<id<SuggestionsCommands>>(self.alerter) openFaviconAtIndex:index];
marq (ping after 24h) 2017/01/19 16:20:26 I'm going to again suggest you just directly assig
marq (ping after 24h) 2017/01/19 16:20:26 Oh, and a minor nit: my current understanding is t
gambard 2017/01/19 17:37:32 Done.
gambard 2017/01/19 17:37:32 Done.
+}
+
@end

Powered by Google App Engine
This is Rietveld 408576698