Suggestions UI - favicon item

ios/showcase/suggestions/sc_suggestions_coordinator.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/showcase/suggestions/sc_suggestions_coordinator.h"
 
 #import "ios/chrome/browser/ui/suggestions/suggestions_commands.h"
 #import "ios/chrome/browser/ui/suggestions/suggestions_view_controller.h"
 #import "ios/showcase/common/protocol_alerter.h"
 
@@ skipping 41 matching lines @@
 
 - (void)openReadingList {
   [static_cast<id<SuggestionsCommands>>(self.alerter) openReadingList];
 }
 
 - (void)openFirstPageOfReadingList {
   [static_cast<id<SuggestionsCommands>>(self.alerter)
       openFirstPageOfReadingList];
 }
 
+- (void)openFaviconAtIndex:(NSInteger)index {
+  [static_cast<id<SuggestionsCommands>>(self.alerter) openFaviconAtIndex:index];

[marq (ping after 24h), 2017/01/19 16:20:26]

I'm going to again suggest you just directly assign the alerter as
_suggestionViewController.suggestionCommandHandler instead of manually
forwarding each method in this way. That's the intended use, specifically so
that when commands are added to a protocol they are supported in the showcase
without any additional code.

[marq (ping after 24h), 2017/01/19 16:20:26]

Oh, and a minor nit: my current understanding is that reinterpret_cast<> is the
right choice here.

[gambard, 2017/01/19 17:37:32]

Done.

[gambard, 2017/01/19 17:37:32]

Done.

+}
+
 @end