Clean the new CRWContextMenuController

Clean the new CRWContextMenuController

- Switch to ARC
- Remove legacy code that detected system gesture recognizers on web
  views.
- Extract the NSDictionary -> ContextMenuParams logic and add unittests.

Note: egtests are already available in context_menu_egtests.

BUG=680930
Review-Url: https://codereview.chromium.org/2640433002
Cr-Commit-Position: refs/heads/master@{#444318}
Committed: https://chromium.googlesource.com/chromium/src/+/44fccdc3a9d6879d4cba838106cae466373475cc

[Olivier, 2017-01-17 10:21:37]

olivierrobin@chromium.org changed reviewers:
+ eugenebut@chromium.org, stkhapugin@chromium.org

[stkhapugin, 2017-01-17 15:13:12]

ARC lgtm with comments

https://codereview.chromium.org/2640433002/diff/20001/ios/web/web_state/ui/cr...
File ios/web/web_state/ui/crw_context_menu_controller.mm (right):

https://codereview.chromium.org/2640433002/diff/20001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_context_menu_controller.mm:75: __weak
id<CRWContextMenuDelegate> _delegate;
Make the |delegate| property weak and @synthesize this ivar, then remove this
line.

https://codereview.chromium.org/2640433002/diff/20001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_context_menu_controller.mm:76: __weak
id<CRWJSInjectionEvaluator> _injectionEvaluator;
ditto

https://codereview.chromium.org/2640433002/diff/20001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_context_menu_controller.mm:77: __weak WKWebView*
_webView;
ditto

[Olivier, 2017-01-17 18:02:14]

Thanks

https://codereview.chromium.org/2640433002/diff/20001/ios/web/web_state/ui/cr...
File ios/web/web_state/ui/crw_context_menu_controller.mm (right):

https://codereview.chromium.org/2640433002/diff/20001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_context_menu_controller.mm:75: __weak
id<CRWContextMenuDelegate> _delegate;
On 2017/01/17 15:13:12, stkhapugin wrote:
> Make the |delegate| property weak and @synthesize this ivar, then remove this
> line. 

Done.

https://codereview.chromium.org/2640433002/diff/20001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_context_menu_controller.mm:76: __weak
id<CRWJSInjectionEvaluator> _injectionEvaluator;
On 2017/01/17 15:13:12, stkhapugin wrote:
> ditto

Done.

https://codereview.chromium.org/2640433002/diff/20001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_context_menu_controller.mm:77: __weak WKWebView*
_webView;
On 2017/01/17 15:13:12, stkhapugin wrote:
> ditto

Done.

[Eugene But (OOO till 7-30), 2017-01-17 18:12:49]

lgtm

https://codereview.chromium.org/2640433002/diff/40001/ios/web/public/web_stat...
File ios/web/public/web_state/context_menu_params.h (right):

https://codereview.chromium.org/2640433002/diff/40001/ios/web/public/web_stat...
ios/web/public/web_state/context_menu_params.h:30:
ContextMenuParams(NSDictionary* element);
This method is specific to ios/web implementation details and I doubt that it
will be useful for any embedder. Can you move it to private part of the web
(f.e. as an utility function in context_menu_params_util)?

https://codereview.chromium.org/2640433002/diff/40001/ios/web/web_state/conte...
File ios/web/web_state/context_menu_params_unittest.mm (right):

https://codereview.chromium.org/2640433002/diff/40001/ios/web/web_state/conte...
ios/web/web_state/context_menu_params_unittest.mm:29: // Test the empty
contructor.
nit: s/Test/Tests

Same comment for other places

[Eugene But (OOO till 7-30), 2017-01-17 18:18:30]

And thank you for cleanup!

[Olivier, 2017-01-18 08:55:54]

https://codereview.chromium.org/2640433002/diff/40001/ios/web/public/web_stat...
File ios/web/public/web_state/context_menu_params.h (right):

https://codereview.chromium.org/2640433002/diff/40001/ios/web/public/web_stat...
ios/web/public/web_state/context_menu_params.h:30:
ContextMenuParams(NSDictionary* element);
On 2017/01/17 18:12:48, Eugene But wrote:
> This method is specific to ios/web implementation details and I doubt that it
> will be useful for any embedder. Can you move it to private part of the web
> (f.e. as an utility function in context_menu_params_util)?

I hesitated :)
Done.

https://codereview.chromium.org/2640433002/diff/40001/ios/web/web_state/conte...
File ios/web/web_state/context_menu_params_unittest.mm (right):

https://codereview.chromium.org/2640433002/diff/40001/ios/web/web_state/conte...
ios/web/web_state/context_menu_params_unittest.mm:29: // Test the empty
contructor.
On 2017/01/17 18:12:48, Eugene But wrote:
> nit: s/Test/Tests
> 
> Same comment for other places

Done.

[Olivier, 2017-01-18 08:55:57]

The CQ bit was checked by olivierrobin@chromium.org

[Olivier, 2017-01-18 08:55:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
stkhapugin@chromium.org, eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2640433002/#ps60001
(title: "feedback")

[commit-bot: I haz the power, 2017-01-18 08:56:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 09:52:47]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484729757940470,
"parent_rev": "5e5d50d1fe1c2322b6b2dc07681fd5804de80346", "commit_rev":
"44fccdc3a9d6879d4cba838106cae466373475cc"}

[commit-bot: I haz the power, 2017-01-18 09:53:22]

Description was changed from

==========
Clean the new CRWContextMenuController

- Switch to ARC
- Remove legacy code that detected system gesture recognizers on web
  views.
- Extract the NSDictionary -> ContextMenuParams logic and add unittests.

Note: egtests are already available in context_menu_egtests.

BUG=680930
==========

to

==========
Clean the new CRWContextMenuController

- Switch to ARC
- Remove legacy code that detected system gesture recognizers on web
  views.
- Extract the NSDictionary -> ContextMenuParams logic and add unittests.

Note: egtests are already available in context_menu_egtests.

BUG=680930

Review-Url: https://codereview.chromium.org/2640433002
Cr-Commit-Position: refs/heads/master@{#444318}
Committed:
https://chromium.googlesource.com/chromium/src/+/44fccdc3a9d6879d4cba838106ca...
==========

[commit-bot: I haz the power, 2017-01-18 09:53:23]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/44fccdc3a9d6879d4cba838106ca...