Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1337)

Issue 2640403002: Revert of Move geolocation timer to frame-specific TaskRunnerTimer. (Closed)

Created:
3 years, 11 months ago by jianli
Modified:
3 years, 11 months ago
Reviewers:
haraken, scheib, dougt
CC:
chromium-reviews, blink-reviews, mlamouri+watch-blink_chromium.org, timvolodine, mvanouwerkerk+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move geolocation timer to frame-specific TaskRunnerTimer. (patchset #2 id:20001 of https://codereview.chromium.org/2642863002/ ) Reason for revert: Seems to be the cause for failed test fast/dom/Geolocation/window-close-crash.html https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/1635 Original issue's description: > Move geolocation timer to frame-specific TaskRunnerTimer. > > Move geolocation timer |m_timer| to frame-specific TaskRunnerTimer. This > associates it with the geolocation frame's timer task queue. Note that the > geolocation specification under specifies exactly what kind of timeout > should be used, and we will use MiscPlatformAPI. See: > > https://www.w3.org/TR/geolocation-API/ > > This m_timer is used to support, in part, the geolocation > 'position options'. > > BUG=624694 > > R=haraken,scheib > > Review-Url: https://codereview.chromium.org/2642863002 > Cr-Commit-Position: refs/heads/master@{#444794} > Committed: https://chromium.googlesource.com/chromium/src/+/d620cdbebcf22fbc7a76c269cf289ab87f5c646d TBR=haraken@chromium.org,scheib@chromium.org,dougt@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624694 Review-Url: https://codereview.chromium.org/2640403002 Cr-Commit-Position: refs/heads/master@{#444839} Committed: https://chromium.googlesource.com/chromium/src/+/dd4298c2034b2f5cf6e58239eb2057e7f91046b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M third_party/WebKit/Source/modules/geolocation/GeoNotifier.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/geolocation/GeoNotifier.cpp View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jianli
Created Revert of Move geolocation timer to frame-specific TaskRunnerTimer.
3 years, 11 months ago (2017-01-19 20:45:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640403002/1
3 years, 11 months ago (2017-01-19 20:45:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/dd4298c2034b2f5cf6e58239eb2057e7f91046b4
3 years, 11 months ago (2017-01-19 20:50:31 UTC) #6
haraken
3 years, 11 months ago (2017-01-20 00:07:53 UTC) #7
Message was sent while issue was closed.
LGTM to revert

Powered by Google App Engine
This is Rietveld 408576698