Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 2640393002: HDR preparations (Closed)

Created:
3 years, 11 months ago by hubbe
Modified:
3 years, 11 months ago
Reviewers:
ccameron
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

HDR preparations 1. Make HDR transfer functions return values greater than 1.0 2. Add IsHDR() to gfx::ColorSpace 3. Add CreateSCRGB() to gfx::ColorSpace BUG=682416 Review-Url: https://codereview.chromium.org/2640393002 Cr-Commit-Position: refs/heads/master@{#444878} Committed: https://chromium.googlesource.com/chromium/src/+/71cc0f83777bfa22f2286efd81b297680bfee4bd

Patch Set 1 #

Total comments: 2

Patch Set 2 : scRGB -> scRGBLinear #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -5 lines) Patch
M ui/gfx/color_space.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M ui/gfx/color_space.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download
M ui/gfx/color_transform.cc View 4 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
hubbe
3 years, 11 months ago (2017-01-19 20:08:59 UTC) #2
ccameron
lgtm % renaming of scRGB Rubber-stamping the math. https://codereview.chromium.org/2640393002/diff/1/ui/gfx/color_space.h File ui/gfx/color_space.h (right): https://codereview.chromium.org/2640393002/diff/1/ui/gfx/color_space.h#newcode155 ui/gfx/color_space.h:155: static ...
3 years, 11 months ago (2017-01-19 21:18:24 UTC) #7
hubbe
https://codereview.chromium.org/2640393002/diff/1/ui/gfx/color_space.h File ui/gfx/color_space.h (right): https://codereview.chromium.org/2640393002/diff/1/ui/gfx/color_space.h#newcode155 ui/gfx/color_space.h:155: static ColorSpace CreateSCRGB(); On 2017/01/19 21:18:24, ccameron wrote: > ...
3 years, 11 months ago (2017-01-19 21:35:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640393002/20001
3 years, 11 months ago (2017-01-19 21:36:32 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 23:09:55 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/71cc0f83777bfa22f2286efd81b2...

Powered by Google App Engine
This is Rietveld 408576698