Add support for audio/{x-}mpegurl mime type for HLS.

Add support for audio/{x-}mpegurl mime type for HLS.

I.e., add support for audio/mpegurl and audio/x-mpegurl.

Sadly, despite documentation indicating that audio/x-mpegurl is not a
standard mime-type, Apple's HLS validator and HLS example site itself
reports this mime type as valid for HLS serving. audio/mpegurl is
specified in the documentation, so also add support for it.

BUG=675552
TEST=updated unittests

Review-Url: https://codereview.chromium.org/2640373002
Cr-Commit-Position: refs/heads/master@{#444934}
Committed: https://chromium.googlesource.com/chromium/src/+/fb0830575b5d15718194f802d48c80e6450eddde

[DaleCurtis, 2017-01-19 20:40:00]

Description was changed from

==========
Add support for audio/x-mpegurl mime type for HLS.

Sadly, despite documentation indicating that this is not a standard
mime-type, Apple's HLS validator and HLS example site itself reports
this mime type as valid for HLS serving. There are numerous in the
wild examples, so go ahead and accept it as part of the HLS types.

BUG=675552
TEST=updated unittests
==========

to

==========
Add support for audio/{x-}mpegurl mime type for HLS.

I.e., add support for audio/mpegurl and audio/x-mpegurl.

Sadly, despite documentation indicating that audio/x-mpegurl is not a
standard mime-type, Apple's HLS validator and HLS example site itself
reports this mime type as valid for HLS serving. audio/mpegurl is
specified in the documentation, so also add support for it.

BUG=675552
TEST=updated unittests
==========

[DaleCurtis, 2017-01-19 20:53:45]

dalecurtis@chromium.org changed reviewers:
+ ddorwin@chromium.org

[ddorwin, 2017-01-19 21:18:25]

LGTM with comments. I did not review the code refactored to TestHLSCombinations.

https://codereview.chromium.org/2640373002/diff/20001/media/base/mime_util_in...
File media/base/mime_util_internal.cc (right):

https://codereview.chromium.org/2640373002/diff/20001/media/base/mime_util_in...
media/base/mime_util_internal.cc:366: // http://crbug.com/67552 for details and
examples.
The ID is missing a '5'. Also, nit: httpS.

https://codereview.chromium.org/2640373002/diff/20001/media/base/mime_util_in...
media/base/mime_util_internal.cc:511: if (base::EndsWith(mime_type_lower_case,
"mpegurl",
It might be better to wrap this in IsHlsMimeType().

[DaleCurtis, 2017-01-19 22:32:18]

The CQ bit was checked by dalecurtis@chromium.org

[DaleCurtis, 2017-01-19 22:32:19]

To be clear, code in TestHLSCombinations is a straight copy with variable
injection. Thanks for review!

https://codereview.chromium.org/2640373002/diff/20001/media/base/mime_util_in...
File media/base/mime_util_internal.cc (right):

https://codereview.chromium.org/2640373002/diff/20001/media/base/mime_util_in...
media/base/mime_util_internal.cc:366: // http://crbug.com/67552 for details and
examples.
On 2017/01/19 at 21:18:25, ddorwin wrote:
> The ID is missing a '5'. Also, nit: httpS.

Done.

https://codereview.chromium.org/2640373002/diff/20001/media/base/mime_util_in...
media/base/mime_util_internal.cc:511: if (base::EndsWith(mime_type_lower_case,
"mpegurl",
On 2017/01/19 at 21:18:25, ddorwin wrote:
> It might be better to wrap this in IsHlsMimeType().

It's not used anywhere else and technically doesn't fully check the mime type
since it relies on previous verification, so I think it makes more sense to keep
it inline.

[DaleCurtis, 2017-01-19 22:32:19]

The patchset sent to the CQ was uploaded after l-g-t-m from ddorwin@chromium.org
Link to the patchset: https://codereview.chromium.org/2640373002/#ps40001
(title: "Fix bug comment.")

[commit-bot: I haz the power, 2017-01-19 22:33:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[DaleCurtis, 2017-01-20 00:06:58]

The CQ bit was checked by dalecurtis@chromium.org

[DaleCurtis, 2017-01-20 00:06:59]

The patchset sent to the CQ was uploaded after l-g-t-m from ddorwin@chromium.org
Link to the patchset: https://codereview.chromium.org/2640373002/#ps60001
(title: "Fix test expectations.")

[commit-bot: I haz the power, 2017-01-20 00:07:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 01:47:25]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484870818819540,
"parent_rev": "896b0f4ea756385f66de7b31c52fccf728a02cb6", "commit_rev":
"fb0830575b5d15718194f802d48c80e6450eddde"}

[commit-bot: I haz the power, 2017-01-20 01:47:55]

Description was changed from

==========
Add support for audio/{x-}mpegurl mime type for HLS.

I.e., add support for audio/mpegurl and audio/x-mpegurl.

Sadly, despite documentation indicating that audio/x-mpegurl is not a
standard mime-type, Apple's HLS validator and HLS example site itself
reports this mime type as valid for HLS serving. audio/mpegurl is
specified in the documentation, so also add support for it.

BUG=675552
TEST=updated unittests
==========

to

==========
Add support for audio/{x-}mpegurl mime type for HLS.

I.e., add support for audio/mpegurl and audio/x-mpegurl.

Sadly, despite documentation indicating that audio/x-mpegurl is not a
standard mime-type, Apple's HLS validator and HLS example site itself
reports this mime type as valid for HLS serving. audio/mpegurl is
specified in the documentation, so also add support for it.

BUG=675552
TEST=updated unittests

Review-Url: https://codereview.chromium.org/2640373002
Cr-Commit-Position: refs/heads/master@{#444934}
Committed:
https://chromium.googlesource.com/chromium/src/+/fb0830575b5d15718194f802d48c...
==========

[commit-bot: I haz the power, 2017-01-20 01:47:56]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/fb0830575b5d15718194f802d48c...