Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2640363003: Fix api test IndependentWeakHandle (Closed)

Created:
3 years, 11 months ago by Michael Lippautz
Modified:
3 years, 11 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix api test IndependentWeakHandle BUG=v8:5865 Review-Url: https://codereview.chromium.org/2640363003 Cr-Commit-Position: refs/heads/master@{#42525} Committed: https://chromium.googlesource.com/v8/v8/+/32228ff2c13ebc14fc1c40752fa8dd2c6b7e1ad8

Patch Set 1 #

Patch Set 2 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M test/cctest/test-api.cc View 1 3 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Michael Lippautz
Hej Mike, here is a fix to your issue. The problem with using CompileRun is ...
3 years, 11 months ago (2017-01-19 20:38:17 UTC) #5
mvstanton
Fantastic!!! LGTM.
3 years, 11 months ago (2017-01-19 21:12:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640363003/20001
3 years, 11 months ago (2017-01-19 21:29:01 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 21:59:17 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/32228ff2c13ebc14fc1c40752fa8dd2c6b7...

Powered by Google App Engine
This is Rietveld 408576698