Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2640333002: Revert "ash: Add one second grace period For LockScreenIfRequired" (Closed)

Created:
3 years, 11 months ago by Qiang(Joe) Xu
Modified:
3 years, 11 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org, derat+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "ash: Add one second grace period For LockScreenIfRequired" This reverts commit 88b1b7e758f10253dc293c05006c8695fe58079e. changes: Revert the one second grace period for LockScreenIfRequired for m57 and tot, and explore it later. BUG=633304 BUG=680509 Review-Url: https://codereview.chromium.org/2640333002 Cr-Commit-Position: refs/heads/master@{#444787} Committed: https://chromium.googlesource.com/chromium/src/+/bb674e1d750b23fe732ce6f37484e1ca3a4e9d96

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -65 lines) Patch
M ash/system/chromeos/power/tablet_power_button_controller.h View 3 chunks +0 lines, -13 lines 0 comments Download
M ash/system/chromeos/power/tablet_power_button_controller.cc View 5 chunks +3 lines, -28 lines 0 comments Download
M ash/system/chromeos/power/tablet_power_button_controller_unittest.cc View 2 chunks +0 lines, -24 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Qiang(Joe) Xu
Hi Daniel, ptal, thanks!
3 years, 11 months ago (2017-01-19 17:26:24 UTC) #6
Daniel Erat
lgtm
3 years, 11 months ago (2017-01-19 17:56:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640333002/1
3 years, 11 months ago (2017-01-19 18:05:52 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 18:10:56 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bb674e1d750b23fe732ce6f37484...

Powered by Google App Engine
This is Rietveld 408576698