Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2640323003: common/sync/mutexpool: Add mutexpool. (Closed)

Created:
3 years, 11 months ago by dnj
Modified:
3 years, 11 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

common/sync/mutexpool: Add mutexpool. Add mutexpool, an elastic pool of mutexes. BUG=chromium:682465 TEST=unit R=iannucci@chromium.org Review-Url: https://codereview.chromium.org/2640323003 Committed: https://github.com/luci/luci-go/commit/af911dea047b54d246620cef8bd68552873d52c7

Patch Set 1 #

Total comments: 4

Patch Set 2 : Comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -0 lines) Patch
A common/sync/mutexpool/pool.go View 1 1 chunk +86 lines, -0 lines 0 comments Download
A common/sync/mutexpool/pool_test.go View 1 chunk +55 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
dnj
3 years, 11 months ago (2017-01-19 22:22:48 UTC) #1
iannucci
lgtm https://codereview.chromium.org/2640323003/diff/1/common/sync/mutexpool/pool.go File common/sync/mutexpool/pool.go (right): https://codereview.chromium.org/2640323003/diff/1/common/sync/mutexpool/pool.go#newcode25 common/sync/mutexpool/pool.go:25: lock sync.Mutex s/lock/mapLock ? https://codereview.chromium.org/2640323003/diff/1/common/sync/mutexpool/pool.go#newcode35 common/sync/mutexpool/pool.go:35: me.count++ panic ...
3 years, 11 months ago (2017-01-19 22:52:54 UTC) #2
dnj
https://codereview.chromium.org/2640323003/diff/1/common/sync/mutexpool/pool.go File common/sync/mutexpool/pool.go (right): https://codereview.chromium.org/2640323003/diff/1/common/sync/mutexpool/pool.go#newcode25 common/sync/mutexpool/pool.go:25: lock sync.Mutex On 2017/01/19 22:52:54, iannucci wrote: > s/lock/mapLock ...
3 years, 11 months ago (2017-01-19 22:59:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640323003/20001
3 years, 11 months ago (2017-01-20 02:41:45 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 02:49:05 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/af911dea047b54d246620cef8bd68552873d52c7

Powered by Google App Engine
This is Rietveld 408576698