Look at canonical decl, when deciding whether to rename or not.

Look at canonical decl, when deciding whether to rename or not.

This is motivated by an observation that before this CL
blink::V8Document::openMethodCustom got renamed, even though
it has its declaration in a generated header (only the definition
of the method is in a non-generated source file).

BUG=682835
Review-Url: https://codereview.chromium.org/2640283003
Cr-Commit-Position: refs/heads/master@{#445466}
Committed: https://chromium.googlesource.com/chromium/src/+/421a2db9f7cb0ff46bd0d1a89f9ab314737b7308

[Łukasz Anforowicz, 2017-01-21 01:04:00]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org

[Łukasz Anforowicz, 2017-01-21 01:04:01]

Daniel, can you PTAL?

https://codereview.chromium.org/2640283003/diff/20001/tools/clang/rewrite_to_...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/2640283003/diff/20001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:1449:
unless(hasCanonicalDecl(isExpansionInFileMatching(kGeneratedFileRegex))));
These are the only real changes from patchset #1.  The other changes are caused
by an accidental rebasing. :-P

https://codereview.chromium.org/2640283003/diff/20001/tools/clang/rewrite_to_...
File tools/clang/rewrite_to_chrome_style/tests/template-expected.cc (right):

https://codereview.chromium.org/2640283003/diff/20001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/tests/template-expected.cc:365: 
These tests are somewhat unrelated to the main changes in the CL, but I managed
to break these tests with the first patchset - see https://crbug.com/682835#c2
for details.

[dcheng, 2017-01-23 19:14:33]

LGTM

[Łukasz Anforowicz, 2017-01-23 19:27:44]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2017-01-23 19:28:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 20:27:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485199664346630,
"parent_rev": "5525b40703df34b46fd9c5b2244378dd1d4d52c9", "commit_rev":
"421a2db9f7cb0ff46bd0d1a89f9ab314737b7308"}

[commit-bot: I haz the power, 2017-01-23 20:28:04]

Description was changed from

==========
Look at canonical decl, when deciding whether to rename or not.

This is motivated by an observation that before this CL
blink::V8Document::openMethodCustom got renamed, even though
it has its declaration in a generated header (only the definition
of the method is in a non-generated source file).

BUG=682835
==========

to

==========
Look at canonical decl, when deciding whether to rename or not.

This is motivated by an observation that before this CL
blink::V8Document::openMethodCustom got renamed, even though
it has its declaration in a generated header (only the definition
of the method is in a non-generated source file).

BUG=682835

Review-Url: https://codereview.chromium.org/2640283003
Cr-Commit-Position: refs/heads/master@{#445466}
Committed:
https://chromium.googlesource.com/chromium/src/+/421a2db9f7cb0ff46bd0d1a89f9a...
==========

[commit-bot: I haz the power, 2017-01-23 20:28:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/421a2db9f7cb0ff46bd0d1a89f9a...