Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issue 2640283002: Several bug fixes which missed 5.7 (Closed)

Created:
3 years, 11 months ago by Michael Hablich
Modified:
3 years, 11 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.7
Project:
v8
Visibility:
Public.

Description

Several bug fixes which missed 5.7 Merged: [turbofan] Properly assign types to Array/String iterators. Revision: 977038516bbdd0427eacf8be4496e63b451f3ffe Merged: [deoptimizer] Materialize array iterators in the deoptimizer. Revision: 9091eb19be52d695616dc76ad87c0217f7b5b2a0 Merged: [turbofan] Lower JSLoadMessage/JSStoreMessage earlier. Revision: 2af52484cd8e16b1571b1ed760d2d043cf0169b7 BUG=chromium:681383, v8:4586, v8:5448, v8:5448 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=bmeurer@chromium.org, jarin@chromium.org Review-Url: https://codereview.chromium.org/2640283002 . Cr-Commit-Position: refs/branch-heads/5.7@{#5} Cr-Branched-From: 975e9a320b6eaf9f12280c35df98e013beb8f041-refs/heads/5.7.492@{#1} Cr-Branched-From: 8d76f0e3465a84bbf0bceab114900fbe75844e1f-refs/heads/master@{#42426} Committed: https://chromium.googlesource.com/v8/v8/+/bd811fb71437114e20a8bd92ef38e8d51d7bb955

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+413 lines, -228 lines) Patch
M src/compiler/access-builder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +2 lines, -14 lines 0 comments Download
M src/compiler/js-operator.cc View 1 chunk +20 lines, -20 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +26 lines, -0 lines 0 comments Download
M src/deoptimizer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/deoptimizer.cc View 6 chunks +327 lines, -194 lines 0 comments Download
A test/mjsunit/regress/regress-681383.js View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Hablich
3 years, 11 months ago (2017-01-19 14:14:11 UTC) #1
Michael Hablich
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
3 years, 11 months ago (2017-01-19 14:14:12 UTC) #2
Benedikt Meurer
LGTM
3 years, 11 months ago (2017-01-19 14:14:49 UTC) #3
Michael Hablich
3 years, 11 months ago (2017-01-19 14:15:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bd811fb71437114e20a8bd92ef38e8d51d7bb955.

Powered by Google App Engine
This is Rietveld 408576698