Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2640243005: Align layers for ARC notification surface to pixels (Closed)

Created:
3 years, 11 months ago by oshima
Modified:
3 years, 11 months ago
Reviewers:
Yusuke Sato
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, sadrul, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, kalyank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Align layers for ARC notification surface to pixels * add more debug info when printing window hierarchy. BUG=680235 Review-Url: https://codereview.chromium.org/2640243005 Cr-Commit-Position: refs/heads/master@{#444893} Committed: https://chromium.googlesource.com/chromium/src/+/37ae087385971464af6724e5670de71b0d8e6145

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M ash/common/accelerators/debug_commands.cc View 2 chunks +9 lines, -1 line 0 comments Download
M ash/wm/window_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/arc/notification/arc_custom_notification_view.cc View 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
oshima
3 years, 11 months ago (2017-01-19 22:05:51 UTC) #4
Yusuke Sato
lgtm
3 years, 11 months ago (2017-01-19 22:42:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640243005/20001
3 years, 11 months ago (2017-01-19 23:57:06 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 00:46:32 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/37ae087385971464af6724e5670d...

Powered by Google App Engine
This is Rietveld 408576698