Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2640223004: Remove ScopedVector in //components/bubble. (Closed)

Created:
3 years, 11 months ago by ke.he
Modified:
3 years, 11 months ago
Reviewers:
hcarmona
CC:
chromium-reviews, msw+watch_chromium.org, groby+bubble_chromium.org, rouslan+bubble_chromium.org, hcarmona+bubble_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScopedVector in //components/bubble. BUG=554289 Review-Url: https://codereview.chromium.org/2640223004 Cr-Commit-Position: refs/heads/master@{#445635} Committed: https://chromium.googlesource.com/chromium/src/+/ca350bd03d0ee72203c44e0f708d04747e68eb27

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M components/bubble/bubble_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/bubble/bubble_manager.cc View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
ke.he
Hi, hcarmona@, Could you PTAL on this, Thanks very much.
3 years, 11 months ago (2017-01-20 06:57:12 UTC) #5
hcarmona
lgtm
3 years, 11 months ago (2017-01-23 16:06:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640223004/1
3 years, 11 months ago (2017-01-24 03:04:40 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 03:57:17 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ca350bd03d0ee72203c44e0f708d...

Powered by Google App Engine
This is Rietveld 408576698