Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 26402002: [Android] Some clean up in pylib. (Closed)

Created:
7 years, 2 months ago by frankf
Modified:
7 years, 2 months ago
Reviewers:
craigdh, bulach
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

[Android] Clean up build/android and tools/android - Remove the place holder modules - Remove unused device_status_monitor - Remove unused fake_dns R=bulach@chromium.org, craigdh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228558

Patch Set 1 : #

Patch Set 2 : Remove fake_dns and device_stats_monitor all together #

Patch Set 3 : Rebsed #

Patch Set 4 : Remove shebang lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -859 lines) Patch
M build/all_android.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D build/android/device_stats_monitor.py View 1 chunk +0 lines, -43 lines 0 comments Download
M build/android/pylib/android_commands.py View 1 2 2 chunks +18 lines, -2 lines 0 comments Download
D build/android/pylib/device_stats_monitor.html View 1 chunk +0 lines, -143 lines 0 comments Download
D build/android/pylib/device_stats_monitor.py View 1 chunk +0 lines, -116 lines 0 comments Download
D build/android/pylib/fake_dns.py View 1 chunk +0 lines, -61 lines 0 comments Download
D build/android/pylib/io_stats_parser.py View 1 1 chunk +0 lines, -32 lines 0 comments Download
D build/android/pylib/surface_stats_collector.py View 1 chunk +0 lines, -10 lines 0 comments Download
D build/android/pylib/thermal_throttle.py View 1 chunk +0 lines, -12 lines 0 comments Download
M build/android/pylib/utils/emulator.py View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M build/android/pylib/utils/findbugs.py View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M tools/android/android_tools.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/android/device_stats_monitor/device_stats_monitor.cc View 1 1 chunk +0 lines, -108 lines 0 comments Download
D tools/android/device_stats_monitor/device_stats_monitor.gyp View 1 1 chunk +0 lines, -41 lines 0 comments Download
D tools/android/fake_dns/DEPS View 1 1 chunk +0 lines, -3 lines 0 comments Download
D tools/android/fake_dns/fake_dns.cc View 1 1 chunk +0 lines, -238 lines 0 comments Download
D tools/android/fake_dns/fake_dns.gyp View 1 1 chunk +0 lines, -44 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
frankf
7 years, 2 months ago (2013-10-08 00:08:16 UTC) #1
frankf
bulach is OOO. Craig, ptal.
7 years, 2 months ago (2013-10-08 20:16:31 UTC) #2
craigdh
lgtm. Please make sure none of these are used downstream or in telemetry.
7 years, 2 months ago (2013-10-08 20:46:00 UTC) #3
frankf
In the latest patch I removed the obsolete targets all together. Note that fake_dns is ...
7 years, 2 months ago (2013-10-09 18:13:52 UTC) #4
bulach
lgtm, thanks!!!
7 years, 2 months ago (2013-10-14 18:00:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/frankf@chromium.org/26402002/20001
7 years, 2 months ago (2013-10-14 18:06:42 UTC) #6
commit-bot: I haz the power
Failed to apply patch for build/all_android.gyp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 2 months ago (2013-10-14 18:06:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/frankf@chromium.org/26402002/32001
7 years, 2 months ago (2013-10-14 18:19:22 UTC) #8
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=88434
7 years, 2 months ago (2013-10-14 21:21:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/frankf@chromium.org/26402002/32001
7 years, 2 months ago (2013-10-14 21:50:21 UTC) #10
frankf
7 years, 2 months ago (2013-10-14 23:27:11 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 manually as r228558 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698