Add TEAM/COMPONENT information

Please help us to verify the TEAM/COMPONENT information. If the current information is incorrect, please suggest the correct team or component or None(if not applicable). 

BUG=679905
R=jsbell

Review-Url: https://codereview.chromium.org/2640193002
Cr-Commit-Position: refs/heads/master@{#445271}
Committed: https://chromium.googlesource.com/chromium/src/+/7089558bf9eca47ae5f55e63b0b3aa801c4cdd82

[ymzhang1, 2017-01-18 22:53:35]

Description was changed from

==========
remove general directory team/compo


Merge branch 'master' of https://chromium.googlesource.com/chromium/src into
jsbell_adding


add team compo information

BUG=
==========

to

==========
Please help us to verify the TEAM/COMPONENT information. If the current
information is incorrect, please suggest the correct team or component or
None(if not applicable). 

BUG=679905
R=jsbell
==========

[ymzhang1, 2017-01-18 22:53:51]

ymzhang@chromium.org changed reviewers:
+ jsbell@chromium.org

[ymzhang1, 2017-01-18 22:54:20]

Hello, 

We are adding COMPONENT/TEAM information into OWNERS file. Would you mind
helping us to verify the added TEAM/COMPONENT or suggest the correct
TEAM/COMPONENT in your OWNERS file? Thank you very much!

[Marijn Kruisselbrink, 2017-01-18 23:01:09]

drive-by-comment

https://codereview.chromium.org/2640193002/diff/1/content/renderer/dom_storag...
File content/renderer/dom_storage/OWNERS (right):

https://codereview.chromium.org/2640193002/diff/1/content/renderer/dom_storag...
content/renderer/dom_storage/OWNERS:8: # COMPONENT: Blink>Storage>DOMStorage
nit: should probably also have this team/component in the other
content/*/dom_storage directories (browser/ and common/)? Or maybe that's in a
different CL, no idea how these things are split up.

https://codereview.chromium.org/2640193002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/storage/OWNERS (right):

https://codereview.chromium.org/2640193002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/storage/OWNERS:5: # COMPONENT: Blink>Storage
this should probably be Blink>Storage>DOMStorage

[ymzhang1, 2017-01-19 00:30:36]

https://codereview.chromium.org/2640193002/diff/1/content/renderer/dom_storag...
File content/renderer/dom_storage/OWNERS (right):

https://codereview.chromium.org/2640193002/diff/1/content/renderer/dom_storag...
content/renderer/dom_storage/OWNERS:8: # COMPONENT: Blink>Storage>DOMStorage
On 2017/01/18 23:01:09, Marijn Kruisselbrink wrote:
> nit: should probably also have this team/component in the other
> content/*/dom_storage directories (browser/ and common/)? Or maybe that's in a
> different CL, no idea how these things are split up.

The CLs are split based on owners for now :)

https://codereview.chromium.org/2640193002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/storage/OWNERS (right):

https://codereview.chromium.org/2640193002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/storage/OWNERS:5: # COMPONENT: Blink>Storage
On 2017/01/18 23:01:09, Marijn Kruisselbrink wrote:
> this should probably be Blink>Storage>DOMStorage

Done.

[ymzhang1, 2017-01-19 00:31:25]

ymzhang@chromium.org changed reviewers:
+ mek@chromium.org

[jsbell, 2017-01-19 17:20:00]

chrome-owp-storage@chromium.org is not a mailing list that actually exists; it's
chrome-owp-storage@google.com address - we don't have our own public list.

[jsbell, 2017-01-19 17:22:30]

https://codereview.chromium.org/2640193002/diff/20001/chrome/browser/storage/...
File chrome/browser/storage/OWNERS (right):

https://codereview.chromium.org/2640193002/diff/20001/chrome/browser/storage/...
chrome/browser/storage/OWNERS:8: # COMPONENT: Blink>Storage
Blink>Storage>DOMStorage

https://codereview.chromium.org/2640193002/diff/20001/content/common/cache_st...
File content/common/cache_storage/OWNERS (right):

https://codereview.chromium.org/2640193002/diff/20001/content/common/cache_st...
content/common/cache_storage/OWNERS:10: # COMPONENT: Blink>Storage
Blink>Storage>CacheStorage

https://codereview.chromium.org/2640193002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/quota/OWNERS (right):

https://codereview.chromium.org/2640193002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/quota/OWNERS:7: # COMPONENT: Blink>Storage
Blink>Storage>Quota

[ymzhang1, 2017-01-19 22:51:35]

Update chrome-owp-storage@chromium.org to chrome-owp-storage@google.com.

https://codereview.chromium.org/2640193002/diff/20001/chrome/browser/storage/...
File chrome/browser/storage/OWNERS (right):

https://codereview.chromium.org/2640193002/diff/20001/chrome/browser/storage/...
chrome/browser/storage/OWNERS:8: # COMPONENT: Blink>Storage
On 2017/01/19 17:22:30, jsbell wrote:
> Blink>Storage>DOMStorage

Done.

https://codereview.chromium.org/2640193002/diff/20001/content/common/cache_st...
File content/common/cache_storage/OWNERS (right):

https://codereview.chromium.org/2640193002/diff/20001/content/common/cache_st...
content/common/cache_storage/OWNERS:10: # COMPONENT: Blink>Storage
On 2017/01/19 17:22:30, jsbell wrote:
> Blink>Storage>CacheStorage

Done.

https://codereview.chromium.org/2640193002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/quota/OWNERS (right):

https://codereview.chromium.org/2640193002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/quota/OWNERS:7: # COMPONENT: Blink>Storage
On 2017/01/19 17:22:30, jsbell wrote:
> Blink>Storage>Quota

Done.

[nhiroki, 2017-01-20 00:12:15]

On 2017/01/19 17:20:00, jsbell wrote:
> mailto:chrome-owp-storage@chromium.org is not a mailing list that actually
exists; it's
> mailto:chrome-owp-storage@google.com address - we don't have our own public
list.

How about storage-dev@chromium.org?
https://groups.google.com/a/chromium.org/forum/#!forum/storage-dev

[nhiroki, 2017-01-20 00:14:36]

nhiroki@chromium.org changed reviewers:
+ nhiroki@chromium.org

[nhiroki, 2017-01-20 00:14:37]

https://codereview.chromium.org/2640193002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/serviceworkers/OWNERS (right):

https://codereview.chromium.org/2640193002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/serviceworkers/OWNERS:9: # TEAM:
blink-worker@chromium.org
blink-worker@chromium.org does not exist. Can you use worker-dev@chromium.org
instead?

https://codereview.chromium.org/2640193002/diff/40001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/modules/serviceworker/OWNERS (right):

https://codereview.chromium.org/2640193002/diff/40001/third_party/WebKit/publ...
third_party/WebKit/public/platform/modules/serviceworker/OWNERS:12: # TEAM:
blink-worker@chromium.org
ditto.

https://codereview.chromium.org/2640193002/diff/40001/third_party/WebKit/publ...
File third_party/WebKit/public/web/modules/serviceworker/OWNERS (right):

https://codereview.chromium.org/2640193002/diff/40001/third_party/WebKit/publ...
third_party/WebKit/public/web/modules/serviceworker/OWNERS:9: # TEAM:
blink-worker@chromium.org
ditto.

[ymzhang1, 2017-01-20 17:14:22]

Shall I use storage-dev@chromium.org to replace all
chrome-owp-storage@google.com? 
(IMO: public mailing may be better)

https://codereview.chromium.org/2640193002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/serviceworkers/OWNERS (right):

https://codereview.chromium.org/2640193002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/serviceworkers/OWNERS:9: # TEAM:
blink-worker@chromium.org
On 2017/01/20 00:14:36, nhiroki wrote:
> mailto:blink-worker@chromium.org does not exist. Can you use
mailto:worker-dev@chromium.org
> instead?

Done.

https://codereview.chromium.org/2640193002/diff/40001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/modules/serviceworker/OWNERS (right):

https://codereview.chromium.org/2640193002/diff/40001/third_party/WebKit/publ...
third_party/WebKit/public/platform/modules/serviceworker/OWNERS:12: # TEAM:
blink-worker@chromium.org
On 2017/01/20 00:14:36, nhiroki wrote:
> ditto.

Done.

https://codereview.chromium.org/2640193002/diff/40001/third_party/WebKit/publ...
File third_party/WebKit/public/web/modules/serviceworker/OWNERS (right):

https://codereview.chromium.org/2640193002/diff/40001/third_party/WebKit/publ...
third_party/WebKit/public/web/modules/serviceworker/OWNERS:9: # TEAM:
blink-worker@chromium.org
On 2017/01/20 00:14:36, nhiroki wrote:
> ditto.

Done.

[jsbell, 2017-01-20 17:36:49]

On 2017/01/20 17:14:22, ymzhang1 wrote:
> Shall I use mailto:storage-dev@chromium.org to replace all
> mailto:chrome-owp-storage@google.com? 
> (IMO: public mailing may be better)
> 

I forgot about that mailing list! Despite having 100 members I don't think it's
used much. But that does make sense and we should use it more.

So: yes!

[ymzhang1, 2017-01-20 17:49:37]

Done. Upate with storage-dev@chromium.org.

[jsbell, 2017-01-20 19:28:41]

lgtm with one tweak

https://codereview.chromium.org/2640193002/diff/80001/third_party/snappy/OWNERS
File third_party/snappy/OWNERS (right):

https://codereview.chromium.org/2640193002/diff/80001/third_party/snappy/OWNE...
third_party/snappy/OWNERS:5: # COMPONENT: Internals>GPU>SwiftShader
huh, where did that component come from?

Should probably be:

TEAM: storage-dev@chromium.org
COMPONENT: Blink>Storage

(sorry, missed this the first time around)

[ymzhang1, 2017-01-20 19:41:21]

https://codereview.chromium.org/2640193002/diff/80001/third_party/snappy/OWNERS
File third_party/snappy/OWNERS (right):

https://codereview.chromium.org/2640193002/diff/80001/third_party/snappy/OWNE...
third_party/snappy/OWNERS:5: # COMPONENT: Internals>GPU>SwiftShader
On 2017/01/20 19:28:41, jsbell wrote:
> huh, where did that component come from?
> 
> Should probably be:
> 
> TEAM: mailto:storage-dev@chromium.org
> COMPONENT: Blink>Storage
> 
> (sorry, missed this the first time around)

Done.

https://codereview.chromium.org/2640193002/diff/80001/third_party/snappy/OWNE...
third_party/snappy/OWNERS:5: # COMPONENT: Internals>GPU>SwiftShader
On 2017/01/20 19:28:41, jsbell wrote:
> huh, where did that component come from?
> 
> Should probably be:
> 
> TEAM: mailto:storage-dev@chromium.org
> COMPONENT: Blink>Storage
> 
> (sorry, missed this the first time around)

The component comes from a prediction system with directory path as input. It
learns from the directory-component mapping we collected in the past, and
predict component for unseen directories. The model is somehow biased now and
suggests some unreasonable result sometimes :P.

[ymzhang1, 2017-01-21 01:52:43]

The CQ bit was checked by ymzhang@chromium.org

[ymzhang1, 2017-01-21 01:52:44]

The patchset sent to the CQ was uploaded after l-g-t-m from jsbell@chromium.org
Link to the patchset: https://codereview.chromium.org/2640193002/#ps100001
(title: "update team/compo")

[commit-bot: I haz the power, 2017-01-21 01:53:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 04:25:34]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484963563950560,
"parent_rev": "fdd566ad2d6598b104ea75b4ae2395a96083ca20", "commit_rev":
"7089558bf9eca47ae5f55e63b0b3aa801c4cdd82"}

[commit-bot: I haz the power, 2017-01-21 04:26:03]

Description was changed from

==========
Please help us to verify the TEAM/COMPONENT information. If the current
information is incorrect, please suggest the correct team or component or
None(if not applicable). 

BUG=679905
R=jsbell
==========

to

==========
Please help us to verify the TEAM/COMPONENT information. If the current
information is incorrect, please suggest the correct team or component or
None(if not applicable). 

BUG=679905
R=jsbell

Review-Url: https://codereview.chromium.org/2640193002
Cr-Commit-Position: refs/heads/master@{#445271}
Committed:
https://chromium.googlesource.com/chromium/src/+/7089558bf9eca47ae5f55e63b0b3...
==========

[commit-bot: I haz the power, 2017-01-21 04:26:06]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/7089558bf9eca47ae5f55e63b0b3...