Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2640153006: Fix Win/Clang components build of cc_unittests (Closed)

Created:
3 years, 11 months ago by hans
Modified:
3 years, 11 months ago
Reviewers:
sunnyps
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Win/Clang components build of cc_unittests This works around a Clang bug by moving TileManager::ResetSignalsForTesting() out-of-line (see bug for details). BUG=682754 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2640153006 Cr-Commit-Position: refs/heads/master@{#444887} Committed: https://chromium.googlesource.com/chromium/src/+/d43836ab1e9e7d511128f58e0009966b1ee78ffe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M cc/tiles/tile_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/tiles/tile_manager.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
hans
sunnyps: Please take a look and CQ if this looks OK.
3 years, 11 months ago (2017-01-19 21:50:52 UTC) #3
sunnyps
lgtm
3 years, 11 months ago (2017-01-19 22:27:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640153006/1
3 years, 11 months ago (2017-01-19 22:28:30 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 23:24:56 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d43836ab1e9e7d511128f58e0009...

Powered by Google App Engine
This is Rietveld 408576698