Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 2640153003: ServiceWorker: Migrate Timer to TaskRunnerTimer in WaitUntilObserver (Closed)

Created:
3 years, 11 months ago by nhiroki
Modified:
3 years, 11 months ago
Reviewers:
haraken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, nhiroki, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Migrate Timer to TaskRunnerTimer in WaitUntilObserver This is a part of the project to migrate from per-renderer scheduler to per-frame scheduler. A general design doc about the project is available here: https://docs.google.com/document/d/10It1DFRP7H3gev9hQA-7dtTcvcMFhrxuCt3-k21yjgQ/edit?usp=sharing BUG=624694 Review-Url: https://codereview.chromium.org/2640153003 Cr-Commit-Position: refs/heads/master@{#444731} Committed: https://chromium.googlesource.com/chromium/src/+/572d21ae9f7c4b3047f5d274d86e4417764b5be1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
nhiroki
PTAL
3 years, 11 months ago (2017-01-19 13:36:32 UTC) #8
haraken
LGTM
3 years, 11 months ago (2017-01-19 14:05:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640153003/1
3 years, 11 months ago (2017-01-19 14:46:17 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 14:50:42 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/572d21ae9f7c4b3047f5d274d86e...

Powered by Google App Engine
This is Rietveld 408576698