core/fpdfapi/parser/cpdf_hint_tables.cpp - Issue 2640143003: Update safe numerics package to get bitwise ops

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/parser/cpdf_hint_tables.cpp

Issue 2640143003: Update safe numerics package to get bitwise ops (Closed)

Patch Set: Address reviewer comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/parser/cpdf_hint_tables.cpp

diff --git a/core/fpdfapi/parser/cpdf_hint_tables.cpp b/core/fpdfapi/parser/cpdf_hint_tables.cpp

index 5c0f2a7fbecf372aa07ed120e55387c7a95854ce..e000188e7d687c77759169b599c84dc46d3b9dec 100644

--- a/core/fpdfapi/parser/cpdf_hint_tables.cpp

+++ b/core/fpdfapi/parser/cpdf_hint_tables.cpp

@@ -257,7 +257,7 @@ bool CPDF_HintTables::ReadSharedObjHintTable(CFX_BitStream* hStream,

bit_offset *= 8;

if (!bit_offset.IsValid() || hStream->GetPos() > bit_offset.ValueOrDie())

return false;

- hStream->SkipBits(bit_offset.ValueOrDie() - hStream->GetPos());

+ hStream->SkipBits((bit_offset - hStream->GetPos()).ValueOrDie());

const uint32_t kHeaderSize = 192;

if (hStream->BitsRemaining() < kHeaderSize)