core/fpdfapi/page/fpdf_page_func.cpp - Issue 2640143003: Update safe numerics package to get bitwise ops

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/page/fpdf_page_func.cpp

Issue 2640143003: Update safe numerics package to get bitwise ops (Closed)

Patch Set: Address reviewer comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/page/fpdf_page_func.cpp

diff --git a/core/fpdfapi/page/fpdf_page_func.cpp b/core/fpdfapi/page/fpdf_page_func.cpp

index 672bfc02be8e83b95b43fa228ee24ef5dd58ae4f..9949e052c9bf1747c2d88e7df96c0adfd74f4ffc 100644

--- a/core/fpdfapi/page/fpdf_page_func.cpp

+++ b/core/fpdfapi/page/fpdf_page_func.cpp

@@ -574,10 +574,9 @@ bool CPDF_SampledFunc::v_Call(FX_FLOAT* inputs, FX_FLOAT* results) const {

if (!pSampleData)

return false;

- for (uint32_t j = 0; j < m_nOutputs; j++) {

+ for (uint32_t j = 0; j < m_nOutputs; j++, bitpos += m_nBitsPerSample) {

uint32_t sample =

- GetBits32(pSampleData, bitpos.ValueOrDie() + j * m_nBitsPerSample,

- m_nBitsPerSample);

+ GetBits32(pSampleData, bitpos.ValueOrDie(), m_nBitsPerSample);

FX_FLOAT encoded = (FX_FLOAT)sample;

for (uint32_t i = 0; i < m_nInputs; i++) {

if (index[i] == m_EncodeInfo[i].sizes - 1) {

« no previous file with comments | « core/fpdfapi/page/cpdf_psengine.h ('k') | core/fpdfapi/parser/cpdf_hint_tables.cpp » ('j') | no next file with comments »