Reland: Use xvfb with Ozone CrOS.

Reland: Use xvfb with Ozone CrOS.

We want to switch the majority of Ozone CrOS tests over to run with
--ozone-platform=x11. This requires that test targets with type
'windowed_test_launcher' run using xvfb.

Right now mb.py looks for the arg '--ozone-platform=x11' in the isolate
step, which requires adding a new target for each test we want to add.
Instead, just assume that if use_ozone=true and target_os="chromeos"
then we want to use xvfb.

Ozone CrOS test with type 'windowed_test_launcher' will still need to
have '--ozone-platform=x11' flag added in chromimum.chromiumos.json to
run with Ozone X11. Once most tests pass under with Ozone X11 the
default Ozone platform can be swapped to be x11 and only tests that
should run with headless will require an args entry there.

This was originally landed in http://crrev.com/2587473002 and then
reverted. I had switched gl_unittests to type='windowed_test_launcher'.
gl_unittests for most platforms run on real hardware and this caused the
Linux GPU trybot to crash. Running gl_unittests in xvfb is required for
Ozone as there are no Ozone Chrome OS GPU trybots, so keep the extra
test target.

BUG=671355
Review-Url: https://codereview.chromium.org/2640133002
Cr-Commit-Position: refs/heads/master@{#444727}
Committed: https://chromium.googlesource.com/chromium/src/+/39705684829e901db436c5185961acc4a37034fd

[kylechar, 2017-01-18 21:13:36]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 21:14:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 22:08:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 22:08:16]

Dry run: This issue passed the CQ dry run.

[kylechar, 2017-01-18 22:18:54]

kylechar@chromium.org changed reviewers:
+ dpranke@chromium.org, sadrul@chromium.org

[kylechar, 2017-01-18 22:18:55]

dprank: testing/*, tools/*
sadrul: ui/*

[Dirk Pranke, 2017-01-19 01:58:27]

lgtm

[sadrul, 2017-01-19 04:24:18]

lgtm

[kylechar, 2017-01-19 14:23:36]

Thanks!

+rjkroege and thomasanderson FYI

[kylechar, 2017-01-19 14:25:58]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 14:26:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 14:29:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 14:29:48]

Dry run: This issue passed the CQ dry run.

[kylechar, 2017-01-19 14:31:53]

The CQ bit was checked by kylechar@chromium.org

[commit-bot: I haz the power, 2017-01-19 14:32:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 14:37:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484836313976630,
"parent_rev": "76edc3b46251f2bd425cd5b7bc90922fddb657d7", "commit_rev":
"39705684829e901db436c5185961acc4a37034fd"}

[commit-bot: I haz the power, 2017-01-19 14:38:00]

Description was changed from

==========
Reland: Use xvfb with Ozone CrOS.

We want to switch the majority of Ozone CrOS tests over to run with
--ozone-platform=x11. This requires that test targets with type
'windowed_test_launcher' run using xvfb.

Right now mb.py looks for the arg '--ozone-platform=x11' in the isolate
step, which requires adding a new target for each test we want to add.
Instead, just assume that if use_ozone=true and target_os="chromeos"
then we want to use xvfb.

Ozone CrOS test with type 'windowed_test_launcher' will still need to
have '--ozone-platform=x11' flag added in chromimum.chromiumos.json to
run with Ozone X11. Once most tests pass under with Ozone X11 the
default Ozone platform can be swapped to be x11 and only tests that
should run with headless will require an args entry there.

This was originally landed in http://crrev.com/2587473002 and then
reverted. I had switched gl_unittests to type='windowed_test_launcher'.
gl_unittests for most platforms run on real hardware and this caused the
Linux GPU trybot to crash. Running gl_unittests in xvfb is required for
Ozone as there are no Ozone Chrome OS GPU trybots, so keep the extra
test target.

BUG=671355
==========

to

==========
Reland: Use xvfb with Ozone CrOS.

We want to switch the majority of Ozone CrOS tests over to run with
--ozone-platform=x11. This requires that test targets with type
'windowed_test_launcher' run using xvfb.

Right now mb.py looks for the arg '--ozone-platform=x11' in the isolate
step, which requires adding a new target for each test we want to add.
Instead, just assume that if use_ozone=true and target_os="chromeos"
then we want to use xvfb.

Ozone CrOS test with type 'windowed_test_launcher' will still need to
have '--ozone-platform=x11' flag added in chromimum.chromiumos.json to
run with Ozone X11. Once most tests pass under with Ozone X11 the
default Ozone platform can be swapped to be x11 and only tests that
should run with headless will require an args entry there.

This was originally landed in http://crrev.com/2587473002 and then
reverted. I had switched gl_unittests to type='windowed_test_launcher'.
gl_unittests for most platforms run on real hardware and this caused the
Linux GPU trybot to crash. Running gl_unittests in xvfb is required for
Ozone as there are no Ozone Chrome OS GPU trybots, so keep the extra
test target.

BUG=671355

Review-Url: https://codereview.chromium.org/2640133002
Cr-Commit-Position: refs/heads/master@{#444727}
Committed:
https://chromium.googlesource.com/chromium/src/+/39705684829e901db436c5185961...
==========

[commit-bot: I haz the power, 2017-01-19 14:38:01]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/39705684829e901db436c5185961...