Source/core/rendering/compositing/RenderLayerCompositor.h - Issue 264013002: Allow layers that need squashing to draw into the squashing layer in some cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/compositing/RenderLayerCompositor.h

Issue 264013002: Allow layers that need squashing to draw into the squashing layer in some cases. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Adjust. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/RenderLayer.cpp ('K') | « Source/core/rendering/compositing/CompositedLayerMappingPtr.h ('k') | Source/core/rendering/compositing/RenderLayerCompositor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/compositing/RenderLayerCompositor.h

diff --git a/Source/core/rendering/compositing/RenderLayerCompositor.h b/Source/core/rendering/compositing/RenderLayerCompositor.h

index 194bb8517b70fd9d2c17200e219feccc56c9d61d..b5eeec4cdd8345749b1f7090817171c2bdeec832 100644

--- a/Source/core/rendering/compositing/RenderLayerCompositor.h

+++ b/Source/core/rendering/compositing/RenderLayerCompositor.h

@@ -239,8 +239,14 @@ private:

bool hasUnresolvedDirtyBits();

+ enum NeedsSquashingBehavior {

+ ShouldPaintIntoOwnLayer = 0,

+ ShouldSquash = 1,

+ ShouldPaintIntoSameLayer = 2

+ };

bool squashingWouldExceedSparsityTolerance(const RenderLayer* candidate, const SquashingState&);

- bool canSquashIntoCurrentSquashingOwner(const RenderLayer* candidate, const SquashingState&);

+ NeedsSquashingBehavior computeSquashingBehaviorWhenSquashingRequired(const RenderLayer* candidate, const SquashingState&);

CompositingStateTransitionType computeCompositedLayerUpdate(RenderLayer*);

// Make updates to the layer based on viewport-constrained properties such as position:fixed. This can in turn affect