[wasm] W.validate should not throw on failure

[wasm] W.validate should not throw on failure

R=titzer@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2640113005
Cr-Commit-Position: refs/heads/master@{#42556}
Committed: https://chromium.googlesource.com/v8/v8/+/1b690f43d9c84efc8bf8bd5b648c1106304a707e

[titzer, 2017-01-20 12:03:55]

LGTM modulo naming

https://codereview.chromium.org/2640113005/diff/1/src/wasm/wasm-result.h
File src/wasm/wasm-result.h (right):

https://codereview.chromium.org/2640113005/diff/1/src/wasm/wasm-result.h#newc...
src/wasm/wasm-result.h:123: bool wasm_error_ = false;
Thinking of a better name for this. Looks like it is set whenever an error is
generated but never cleared, so many "any_error"?

[rossberg, 2017-01-20 12:17:22]

https://codereview.chromium.org/2640113005/diff/1/src/wasm/wasm-result.h
File src/wasm/wasm-result.h (right):

https://codereview.chromium.org/2640113005/diff/1/src/wasm/wasm-result.h#newc...
src/wasm/wasm-result.h:123: bool wasm_error_ = false;
On 2017/01/20 12:03:55, titzer wrote:
> Thinking of a better name for this. Looks like it is set whenever an error is
> generated but never cleared, so many "any_error"?

Nah, it's set only for {Compile,Link,Runtime}Error, and distinguishes these from
random JS errors; validate needs to return false for the former, but still throw
the latter.

[rossberg, 2017-01-20 12:53:36]

The CQ bit was checked by rossberg@chromium.org

[commit-bot: I haz the power, 2017-01-20 12:53:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 13:27:05]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484916816505240, "parent_rev":
"0659898b3ed60214b8d25c964bbd47784060430d", "commit_rev":
"1b690f43d9c84efc8bf8bd5b648c1106304a707e"}

[commit-bot: I haz the power, 2017-01-20 13:27:09]

Description was changed from

==========
[wasm] W.validate should not throw on failure

R=titzer@chromium.org
BUG=
==========

to

==========
[wasm] W.validate should not throw on failure

R=titzer@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2640113005
Cr-Commit-Position: refs/heads/master@{#42556}
Committed:
https://chromium.googlesource.com/v8/v8/+/1b690f43d9c84efc8bf8bd5b648c1106304...
==========

[commit-bot: I haz the power, 2017-01-20 13:27:10]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/1b690f43d9c84efc8bf8bd5b648c1106304...