Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2640073002: Fix unused lambda captures in base/ (Closed)

Created:
3 years, 11 months ago by krasin1
Modified:
3 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix unused lambda captures in base/. Clang just got a new warning to warn about unused lambda captures, and that requires us to clean all places with this issue across all the Chromium code base. This CL fixes all such cases in base/. BUG=681912 Review-Url: https://codereview.chromium.org/2640073002 Cr-Commit-Position: refs/heads/master@{#444436} Committed: https://chromium.googlesource.com/chromium/src/+/0a8923f06f3915892d131bd7facaeb8cf6e8847f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/bind_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
krasin1
3 years, 11 months ago (2017-01-18 19:10:58 UTC) #2
Nico
lgtm, but I'd say "clang got a new warning to warn on unused lambda captures" ...
3 years, 11 months ago (2017-01-18 19:21:39 UTC) #5
krasin1
On 2017/01/18 19:21:39, Nico wrote: > lgtm, but I'd say "clang got a new warning ...
3 years, 11 months ago (2017-01-18 19:23:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640073002/1
3 years, 11 months ago (2017-01-18 19:23:32 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 19:30:12 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0a8923f06f3915892d131bd7faca...

Powered by Google App Engine
This is Rietveld 408576698