Add logging for |old_ink_drop_state| when ink drop DCHECKs fail.

Add logging for |old_ink_drop_state| when ink drop DCHECKs fail.

BUG=673030
Review-Url: https://codereview.chromium.org/2640053003
Cr-Commit-Position: refs/heads/master@{#444553}
Committed: https://chromium.googlesource.com/chromium/src/+/93704279f2399dc229df43de3cae57fd83a75a6d

[bruthig, 2017-01-18 22:46:51]

The CQ bit was checked by bruthig@chromium.org to run a CQ dry run

[bruthig, 2017-01-18 22:47:11]

Description was changed from

==========
Adding logging for |old_ink_drop_state| when ink drop DCHECKs fail.

BUG=673030
==========

to

==========
Add logging for |old_ink_drop_state| when ink drop DCHECKs fail.

BUG=673030
==========

[commit-bot: I haz the power, 2017-01-18 22:47:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bruthig, 2017-01-18 22:47:26]

bruthig@chromium.org changed reviewers:
+ msw@chromium.org

[bruthig, 2017-01-18 22:47:27]

msw@, can you take a quick look?

[msw, 2017-01-18 23:37:08]

lgtm with a q

https://codereview.chromium.org/2640053003/diff/1/ui/views/animation/flood_fi...
File ui/views/animation/flood_fill_ink_drop_ripple.cc (right):

https://codereview.chromium.org/2640053003/diff/1/ui/views/animation/flood_fi...
ui/views/animation/flood_fill_ink_drop_ripple.cc:213: << " old_ink_drop_state="
<< ToString(old_ink_drop_state);
q: won't DCHECK_EQ already print the actual value when it doesn't match the
expected value? (ditto for other DCHECK instances you've changed to DCHECK_EQ),
these are fine if it's extra helpful to have the human-readable ToString() value
printed, but perhaps just DCHECK_EQ is enough.

https://codereview.chromium.org/2640053003/diff/1/ui/views/animation/flood_fi...
ui/views/animation/flood_fill_ink_drop_ripple.cc:233: << " old_ink_drop_state="
<< ToString(old_ink_drop_state);
(this one is ok, since it's not a DCHECK_EQ)

[commit-bot: I haz the power, 2017-01-18 23:53:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 23:53:14]

Dry run: This issue passed the CQ dry run.

[bruthig, 2017-01-18 23:53:17]

Sending to CQ

https://codereview.chromium.org/2640053003/diff/1/ui/views/animation/flood_fi...
File ui/views/animation/flood_fill_ink_drop_ripple.cc (right):

https://codereview.chromium.org/2640053003/diff/1/ui/views/animation/flood_fi...
ui/views/animation/flood_fill_ink_drop_ripple.cc:213: << " old_ink_drop_state="
<< ToString(old_ink_drop_state);
On 2017/01/18 23:37:08, msw wrote:
> q: won't DCHECK_EQ already print the actual value when it doesn't match the
> expected value? (ditto for other DCHECK instances you've changed to
DCHECK_EQ),
> these are fine if it's extra helpful to have the human-readable ToString()
value
> printed, but perhaps just DCHECK_EQ is enough.

You're right it will print the int values.  e.g. "(0 vs 1)" but I'm of the
opinion that human readable is better.

[bruthig, 2017-01-18 23:53:22]

The CQ bit was checked by bruthig@chromium.org

[commit-bot: I haz the power, 2017-01-18 23:54:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 23:59:54]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484783602124760, "parent_rev":
"857998f6024697334675af683c89e39d804f45a9", "commit_rev":
"93704279f2399dc229df43de3cae57fd83a75a6d"}

[commit-bot: I haz the power, 2017-01-19 00:00:25]

Description was changed from

==========
Add logging for |old_ink_drop_state| when ink drop DCHECKs fail.

BUG=673030
==========

to

==========
Add logging for |old_ink_drop_state| when ink drop DCHECKs fail.

BUG=673030

Review-Url: https://codereview.chromium.org/2640053003
Cr-Commit-Position: refs/heads/master@{#444553}
Committed:
https://chromium.googlesource.com/chromium/src/+/93704279f2399dc229df43de3cae...
==========

[commit-bot: I haz the power, 2017-01-19 00:00:27]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/93704279f2399dc229df43de3cae...