Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issue 2640043002: [foozzie] Add ignition as baseline comparison (Closed)

Created:
3 years, 11 months ago by Michael Achenbach
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[foozzie] Add ignition as baseline comparison The new ignition config will be used as baseline comparison in new jobs, e.g. against ignition_turbo. We'll keep --validate-asm off in ignition_turbo for now as it is very chatty. BUG=chromium:673246 NOTRY=true Review-Url: https://codereview.chromium.org/2640043002 Cr-Commit-Position: refs/heads/master@{#42464} Committed: https://chromium.googlesource.com/v8/v8/+/c69a40fc57e07a36782dc8f7e64dc96eee5c7679

Patch Set 1 #

Patch Set 2 : updates #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M tools/foozzie/testdata/failure_output.txt View 1 3 chunks +6 lines, -6 lines 0 comments Download
M tools/foozzie/v8_foozzie.py View 1 1 chunk +5 lines, -2 lines 1 comment Download
M tools/foozzie/v8_foozzie_test.py View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/2640043002/diff/20001/tools/foozzie/v8_foozzie.py File tools/foozzie/v8_foozzie.py (right): https://codereview.chromium.org/2640043002/diff/20001/tools/foozzie/v8_foozzie.py#newcode108 tools/foozzie/v8_foozzie.py:108: '--first-config', help='first configuration', default='fullcode') I'd also like to ...
3 years, 11 months ago (2017-01-18 15:18:26 UTC) #4
Michael Starzinger
LGTM (rubber-stamp).
3 years, 11 months ago (2017-01-18 15:22:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640043002/20001
3 years, 11 months ago (2017-01-18 15:22:22 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 15:24:01 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/c69a40fc57e07a36782dc8f7e64dc96eee5...

Powered by Google App Engine
This is Rietveld 408576698