Substitute boolean GDI printing for a mode type

chrome/browser/printing/print_job.cc

Index: chrome/browser/printing/print_job.cc
diff --git a/chrome/browser/printing/print_job.cc b/chrome/browser/printing/print_job.cc
index b00ee4829a53a375dc744e2d803b015a4c737f67..0fcb497f4f42ae90367d83053a09ca6330d850db 100644
--- a/chrome/browser/printing/print_job.cc
+++ b/chrome/browser/printing/print_job.cc
@@ -236,10 +236,8 @@ class PrintJob::PdfConversionState {
 
   void Start(const scoped_refptr<base::RefCountedMemory>& data,
              const PdfRenderSettings& conversion_settings,
-             bool print_text_with_gdi,
              const PdfConverter::StartCallback& start_callback) {
-    converter_->Start(data, conversion_settings, print_text_with_gdi,
-                      start_callback);
+    converter_->Start(data, conversion_settings, start_callback);
   }
 
   void GetMorePages(const PdfConverter::GetPageCallback& get_page_callback) {
@@ -286,9 +284,12 @@ void PrintJob::StartPdfToEmfConversion(
       base::MakeUnique<PdfConversionState>(page_size, content_area,
           PdfConverter::CreatePdfToEmfConverter());
   const int kPrinterDpi = settings().dpi();
-  PdfRenderSettings settings(content_area, kPrinterDpi, true /* autorotate? */);
+  PdfRenderSettings settings(
+      content_area, kPrinterDpi, true /*autorotate? */,

[Nico, 2017/01/26 20:46:05]

nit: spell this like /*autorotate=*/true. For true, it doesn't make a big
difference, but for `false /*autorotate*/` it's not clear if false means
autorotate, or if that sets autorotate to false. (The `?` helps, but the = helps
too and that's fairly widely used in chrome, and clang-format knows not to put a
space after the comment for /*foo=*/ comments)

[rbpotter, 2017/01/26 22:10:50]

Done.

+      print_text_with_gdi ? PdfRenderSettings::Mode::GDI_TEXT
+                          : PdfRenderSettings::Mode::NORMAL);
   pdf_conversion_state_->Start(
-      bytes, settings, print_text_with_gdi,
+      bytes, settings,
       base::Bind(&PrintJob::OnPdfConversionStarted, this));
 }