Substitute boolean GDI printing for a mode type

chrome/browser/printing/print_job.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/printing/print_job.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 218 matching lines @@
                      std::unique_ptr<PdfConverter> converter)
       : page_count_(0),
         current_page_(0),
         pages_in_progress_(0),
         page_size_(page_size),
         content_area_(content_area),
         converter_(std::move(converter)) {}
 
   void Start(const scoped_refptr<base::RefCountedMemory>& data,
              const PdfRenderSettings& conversion_settings,
-             bool print_text_with_gdi,
              const PdfConverter::StartCallback& start_callback) {
-    converter_->Start(data, conversion_settings, print_text_with_gdi,
-                      start_callback);
+    converter_->Start(data, conversion_settings, start_callback);
   }
 
   void GetMorePages(const PdfConverter::GetPageCallback& get_page_callback) {
     const int kMaxNumberOfTempFilesPerDocument = 3;
     while (pages_in_progress_ < kMaxNumberOfTempFilesPerDocument &&
            current_page_ < page_count_) {
       ++pages_in_progress_;
       converter_->GetPage(current_page_++, get_page_callback);
     }
   }
@@ skipping 26 matching lines @@
 void PrintJob::StartPdfToEmfConversion(
     const scoped_refptr<base::RefCountedMemory>& bytes,
     const gfx::Size& page_size,
     const gfx::Rect& content_area,
     bool print_text_with_gdi) {
   DCHECK(!pdf_conversion_state_);
   pdf_conversion_state_ =
       base::MakeUnique<PdfConversionState>(page_size, content_area,
           PdfConverter::CreatePdfToEmfConverter());
   const int kPrinterDpi = settings().dpi();
-  PdfRenderSettings settings(content_area, kPrinterDpi, true /* autorotate? */);
+  PdfRenderSettings settings(
+      content_area, kPrinterDpi, true /*autorotate? */,

[Nico, 2017/01/26 20:46:05]

nit: spell this like /*autorotate=*/true. For true, it doesn't make a big
difference, but for `false /*autorotate*/` it's not clear if false means
autorotate, or if that sets autorotate to false. (The `?` helps, but the = helps
too and that's fairly widely used in chrome, and clang-format knows not to put a
space after the comment for /*foo=*/ comments)

[rbpotter, 2017/01/26 22:10:50]

Done.

+      print_text_with_gdi ? PdfRenderSettings::Mode::GDI_TEXT
+                          : PdfRenderSettings::Mode::NORMAL);
   pdf_conversion_state_->Start(
-      bytes, settings, print_text_with_gdi,
+      bytes, settings,
       base::Bind(&PrintJob::OnPdfConversionStarted, this));
 }
 
 void PrintJob::OnPdfConversionStarted(int page_count) {
   if (page_count <= 0) {
     pdf_conversion_state_.reset();
     Cancel();
     return;
   }
   pdf_conversion_state_->set_page_count(page_count);
@@ skipping 158 matching lines @@
 }
 
 JobEventDetails::~JobEventDetails() {
 }
 
 PrintedDocument* JobEventDetails::document() const { return document_.get(); }
 
 PrintedPage* JobEventDetails::page() const { return page_.get(); }
 
 }  // namespace printing