Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Issue 2640033002: [wrapper-tracing] Force inlining of marking deque helper (Closed)

Created:
3 years, 11 months ago by Michael Lippautz
Modified:
3 years, 11 months ago
Reviewers:
haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[wrapper-tracing] Force inlining of marking deque helper BUG=679510 Review-Url: https://codereview.chromium.org/2640033002 Cr-Commit-Position: refs/heads/master@{#444361} Committed: https://chromium.googlesource.com/chromium/src/+/92b8a98af078e38774b2b1b1818fb0d461f5fc13

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/heap/WrapperVisitor.h View 2 chunks +2 lines, -2 lines 2 comments Download

Messages

Total messages: 12 (8 generated)
Michael Lippautz
https://codereview.chromium.org/2640033002/diff/1/third_party/WebKit/Source/platform/heap/WrapperVisitor.h File third_party/WebKit/Source/platform/heap/WrapperVisitor.h (right): https://codereview.chromium.org/2640033002/diff/1/third_party/WebKit/Source/platform/heap/WrapperVisitor.h#newcode94 third_party/WebKit/Source/platform/heap/WrapperVisitor.h:94: static NOINLINE void missedWriteBarrier() { https://cs.chromium.org/chromium/src/third_party/WebKit/Source/wtf/Compiler.h?q=NEVER_INLINE&sq=package:chromium&dr=CSs&l=66 https://codereview.chromium.org/2640033002/diff/1/third_party/WebKit/Source/platform/heap/WrapperVisitor.h#newcode170 third_party/WebKit/Source/platform/heap/WrapperVisitor.h:170: ALWAYS_INLINE ...
3 years, 11 months ago (2017-01-18 13:47:40 UTC) #2
haraken
LGTM
3 years, 11 months ago (2017-01-18 13:53:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640033002/1
3 years, 11 months ago (2017-01-18 15:21:55 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 15:26:09 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/92b8a98af078e38774b2b1b1818f...

Powered by Google App Engine
This is Rietveld 408576698