[wrapper-tracing] Force inlining of marking deque helper

[wrapper-tracing] Force inlining of marking deque helper

BUG=679510
Review-Url: https://codereview.chromium.org/2640033002
Cr-Commit-Position: refs/heads/master@{#444361}
Committed: https://chromium.googlesource.com/chromium/src/+/92b8a98af078e38774b2b1b1818fb0d461f5fc13

[Michael Lippautz, 2017-01-18 13:47:39]

mlippautz@chromium.org changed reviewers:
+ haraken@chromium.org

[Michael Lippautz, 2017-01-18 13:47:40]

https://codereview.chromium.org/2640033002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/heap/WrapperVisitor.h (right):

https://codereview.chromium.org/2640033002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/WrapperVisitor.h:94: static NOINLINE
void missedWriteBarrier() {
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/wtf/Compiler.h...

https://codereview.chromium.org/2640033002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/WrapperVisitor.h:170: ALWAYS_INLINE void
markAndPushToMarkingDeque(const T* traceable) const {
The only difference in the CL responsible for the perf regression in the bug is
introduction of this small helper function.

I cannot reproduce locally, so let's try to fix this by forcing inlining (which
should make sense for this one anyways).

[Michael Lippautz, 2017-01-18 13:47:44]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 13:47:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-01-18 13:53:57]

LGTM

[commit-bot: I haz the power, 2017-01-18 15:18:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 15:18:09]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2017-01-18 15:21:29]

The CQ bit was checked by mlippautz@chromium.org

[commit-bot: I haz the power, 2017-01-18 15:21:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 15:25:36]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484752889422750, "parent_rev":
"39e00a342e96ee718f07a4d91a1645d5e1e354e9", "commit_rev":
"92b8a98af078e38774b2b1b1818fb0d461f5fc13"}

[commit-bot: I haz the power, 2017-01-18 15:26:08]

Description was changed from

==========
[wrapper-tracing] Force inlining of marking deque helper

BUG=679510
==========

to

==========
[wrapper-tracing] Force inlining of marking deque helper

BUG=679510

Review-Url: https://codereview.chromium.org/2640033002
Cr-Commit-Position: refs/heads/master@{#444361}
Committed:
https://chromium.googlesource.com/chromium/src/+/92b8a98af078e38774b2b1b1818f...
==========

[commit-bot: I haz the power, 2017-01-18 15:26:09]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/92b8a98af078e38774b2b1b1818f...