Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Issue 2639983002: [GeometryInterface] add fromRect function in DOMQuad. (Closed)

Created:
3 years, 11 months ago by Hwanseung Lee
Modified:
3 years, 11 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GeometryInterface] add fromRect function in DOMQuad. The fromRect(other) static method on DOMQuad must create a DOMQuad from the DOMRectInit dictionary other. To create a DOMQuad from a DOMRectInit dictionary other, follow these steps: 1.Let x, y, width and height be the value of other’s x, y, width and height attributes, respectively. 2.Let point 1 be a new DOMPoint object with x set to x, y set to y, z set to zero and w set to one. 3.Let point 2 be a new DOMPoint object with x set to x + width, y set to y, z set to zero and w set to one. 4.Let point 3 be a new DOMPoint object with x set to x + width, y set to y + height, z set to zero and w set to one. 5.Let point 4 be a new DOMPoint object with x set to x, y set to y + height, z set to zero and w set to one. 6.Return a new DOMQuad with p1 set to point 1, p2 set to point 2, p3 set to point 3 and p4 set to point 4. spec list: https://drafts.fxtf.org/geometry/#dom-domquad-fromrect BUG=678237 Review-Url: https://codereview.chromium.org/2639983002 Cr-Commit-Position: refs/heads/master@{#444666} Committed: https://chromium.googlesource.com/chromium/src/+/05e25435cee9bdd3da715ed0725f06ee2b8cdd03

Patch Set 1 #

Patch Set 2 : [GeometryInterface] add fromRect function in DOMQuad. #

Patch Set 3 : [GeometryInterface] add fromRect function in DOMQuad. #

Patch Set 4 : [GeometryInterface] add fromRect function in DOMQuad. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/fast/dom/geometry-interface-dom-quad.html View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMQuad.h View 1 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMQuad.cpp View 1 3 chunks +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMQuad.idl View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (16 generated)
Hwanseung Lee
@dominicc, zino PTAL, thank you,
3 years, 11 months ago (2017-01-18 21:27:07 UTC) #12
dominicc (has gone to gerrit)
lgtm
3 years, 11 months ago (2017-01-19 06:35:11 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2639983002/60001
3 years, 11 months ago (2017-01-19 06:35:31 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 06:40:19 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/05e25435cee9bdd3da715ed0725f...

Powered by Google App Engine
This is Rietveld 408576698