Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2639953002: Worker: Migrate Timer to TaskRunnerTimer in InProcessWorkerObjectProxy (Closed)

Created:
3 years, 11 months ago by nhiroki
Modified:
3 years, 11 months ago
Reviewers:
haraken
CC:
chromium-reviews, shimazu+worker_chromium.org, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Worker: Migrate Timer to TaskRunnerTimer in InProcessWorkerObjectProxy This is a part of the project to migrate from per-renderer scheduler to per-frame scheduler. A general design doc about the project is available here: https://docs.google.com/document/d/10It1DFRP7H3gev9hQA-7dtTcvcMFhrxuCt3-k21yjgQ/edit?usp=sharing BUG=624694 Review-Url: https://codereview.chromium.org/2639953002 Cr-Commit-Position: refs/heads/master@{#444715} Committed: https://chromium.googlesource.com/chromium/src/+/e21c61e6e59cd91d5619a68a6634ca0fefab66d1

Patch Set 1 : WIP #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp View 2 chunks +4 lines, -2 lines 1 comment Download

Messages

Total messages: 17 (11 generated)
nhiroki
PTAL, thanks!
3 years, 11 months ago (2017-01-19 09:55:26 UTC) #9
haraken
LGTM https://codereview.chromium.org/2639953002/diff/1/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp File third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp (right): https://codereview.chromium.org/2639953002/diff/1/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp#newcode118 third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp:118: Platform::current()->currentThread()->getWebTaskRunner(), this, It's unfortunate that we have use ...
3 years, 11 months ago (2017-01-19 11:08:01 UTC) #10
nhiroki
On 2017/01/19 11:08:01, haraken wrote: > LGTM > > https://codereview.chromium.org/2639953002/diff/1/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp > File third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp > (right): ...
3 years, 11 months ago (2017-01-19 11:57:47 UTC) #11
nhiroki
On 2017/01/19 11:57:47, nhiroki wrote: > On 2017/01/19 11:08:01, haraken wrote: > > LGTM > ...
3 years, 11 months ago (2017-01-19 11:58:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2639953002/1
3 years, 11 months ago (2017-01-19 11:59:10 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 13:07:32 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e21c61e6e59cd91d5619a68a6634...

Powered by Google App Engine
This is Rietveld 408576698