Rename WS handshake success error code; update enums.

Rename WS handshake success error code; update enums.

The new error code needs to be added to histograms.xml, as well as some other
values that apparently have been forgotten to be added.

The reason for renaming the error code is that WebSocket error codes start with
a WS_ prefix.

BUG=663672
Review-Url: https://codereview.chromium.org/2639933005
Cr-Commit-Position: refs/heads/master@{#444771}
Committed: https://chromium.googlesource.com/chromium/src/+/2ff3fe13ff8f01226d36f63e9e695bbaf747dbdb

[pkalinnikov, 2017-01-19 12:48:30]

Description was changed from

==========
Rename WS handshake success error code; update enums.

BUG=663672
==========

to

==========
Rename WS handshake success error code; update enums.

The new error code needs to be added to histograms.xml, as well as some other
values that apparently have been forgotten to be added.

The reason for renaming the error code is that WebSocket error codes start with
a WS_ prefix.

BUG=663672
==========

[pkalinnikov, 2017-01-19 12:48:30]

pkalinnikov@chromium.org changed reviewers:
+ davidben@chromium.org, ricea@chromium.org, yhirano@chromium.org

[pkalinnikov, 2017-01-19 12:50:14]

PTAL.

[pkalinnikov, 2017-01-19 12:50:59]

The CQ bit was checked by pkalinnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 12:51:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Adam Rice, 2017-01-19 12:55:10]

Awesome, thanks.

You will also need to rename WEBSOCKET_HANDSHAKE_SUCCESS in
//net/websockets/websocket_stream.cc and
//net/websockets/websocket_stream_test.cc.

[pkalinnikov, 2017-01-19 12:59:22]

The CQ bit was checked by pkalinnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 12:59:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pkalinnikov, 2017-01-19 12:59:37]

Sure, forgot to commit this. Thanks!

[Adam Rice, 2017-01-19 13:12:00]

lgtm

[tyoshino (SeeGerritForStatus), 2017-01-19 13:52:42]

lgtm

[yhirano, 2017-01-19 14:14:13]

lgtm

[commit-bot: I haz the power, 2017-01-19 14:53:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 14:53:05]

Dry run: This issue passed the CQ dry run.

[davidben, 2017-01-19 17:21:29]

lgtm

[pkalinnikov, 2017-01-19 17:23:23]

The CQ bit was checked by pkalinnikov@chromium.org

[commit-bot: I haz the power, 2017-01-19 17:23:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 17:28:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484846603716930,
"parent_rev": "e499c21a7e3500777b05e3b2a3b5ac93da519668", "commit_rev":
"2ff3fe13ff8f01226d36f63e9e695bbaf747dbdb"}

[commit-bot: I haz the power, 2017-01-19 17:29:32]

Description was changed from

==========
Rename WS handshake success error code; update enums.

The new error code needs to be added to histograms.xml, as well as some other
values that apparently have been forgotten to be added.

The reason for renaming the error code is that WebSocket error codes start with
a WS_ prefix.

BUG=663672
==========

to

==========
Rename WS handshake success error code; update enums.

The new error code needs to be added to histograms.xml, as well as some other
values that apparently have been forgotten to be added.

The reason for renaming the error code is that WebSocket error codes start with
a WS_ prefix.

BUG=663672

Review-Url: https://codereview.chromium.org/2639933005
Cr-Commit-Position: refs/heads/master@{#444771}
Committed:
https://chromium.googlesource.com/chromium/src/+/2ff3fe13ff8f01226d36f63e9e69...
==========

[commit-bot: I haz the power, 2017-01-19 17:29:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2ff3fe13ff8f01226d36f63e9e69...

[Wez, 2017-02-07 22:33:20]

wez@chromium.org changed reviewers:
+ ericwilligers@chromium.org

[Wez, 2017-02-07 22:33:20]

Hallo ericwilligers@chromium.org!
Due to a depot_tools patch which mistakenly removed the OWNERS check for
non-source files (see crbug.com/684270), the following files landed in this CL
and need a retrospective review from you:
	tools/metrics/histograms/histograms.xml
Thanks,
Wez

[Eric Willigers, 2017-02-07 22:41:12]

Description was changed from

==========
Rename WS handshake success error code; update enums.

The new error code needs to be added to histograms.xml, as well as some other
values that apparently have been forgotten to be added.

The reason for renaming the error code is that WebSocket error codes start with
a WS_ prefix.

BUG=663672

Review-Url: https://codereview.chromium.org/2639933005
Cr-Commit-Position: refs/heads/master@{#444771}
Committed:
https://chromium.googlesource.com/chromium/src/+/2ff3fe13ff8f01226d36f63e9e69...
==========

to

==========
Rename WS handshake success error code; update enums.

The new error code needs to be added to histograms.xml, as well as some other
values that apparently have been forgotten to be added.

The reason for renaming the error code is that WebSocket error codes start with
a WS_ prefix.

BUG=663672

Review-Url: https://codereview.chromium.org/2639933005
Cr-Commit-Position: refs/heads/master@{#444771}
Committed:
https://chromium.googlesource.com/chromium/src/+/2ff3fe13ff8f01226d36f63e9e69...
==========

[Eric Willigers, 2017-02-07 22:41:12]

ericwilligers@chromium.org changed reviewers:
+ holte@chromium.org
- ericwilligers@chromium.org

[Steven Holte, 2017-02-08 00:34:35]

histograms lgtm