Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2639913002: Move class EditCommandComposition to UndoStep.h/cpp (Closed)

Created:
3 years, 11 months ago by Xiaocheng
Modified:
3 years, 11 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chongz, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move class EditCommandComposition to UndoStep.h/cpp This patch moves class |EditCommandComposition| to UndoStep.h/cpp as a preparation for getting rid of the |UndoStep| interface and using |EditCommandComposition| directly. BUG=682129 TEST=n/a; no behavior change Review-Url: https://codereview.chromium.org/2639913002 Cr-Commit-Position: refs/heads/master@{#444304} Committed: https://chromium.googlesource.com/chromium/src/+/e8238843edf7f903b0ab03ae98a3280138421111

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -139 lines) Patch
M third_party/WebKit/Source/core/editing/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h View 1 chunk +0 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 1 chunk +0 lines, -96 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/UndoStep.h View 2 chunks +48 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/commands/UndoStep.cpp View 1 chunk +108 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
Xiaocheng
PTAL.
3 years, 11 months ago (2017-01-18 07:46:04 UTC) #4
Xiaocheng
+chongz: We are removing the purely virtual interface UndoStep, and letting EditCommandComposition to play its ...
3 years, 11 months ago (2017-01-18 07:48:26 UTC) #5
yosin_UTC9
lgtm Thanks! It makes us less confusing. (^_^)b For me, it is hard to distinguish ...
3 years, 11 months ago (2017-01-18 08:05:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2639913002/1
3 years, 11 months ago (2017-01-18 08:05:50 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 08:36:02 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e8238843edf7f903b0ab03ae98a3...

Powered by Google App Engine
This is Rietveld 408576698