Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 26399003: Remove unused code for v8 tester-only bots. (Closed)

Created:
7 years, 2 months ago by Nico
Modified:
7 years, 2 months ago
Reviewers:
Yang, Michael Achenbach
CC:
chromium-reviews, cmp+cc_chromium.org, kjellander+cc_chromium.org
Visibility:
Public.

Description

Remove unused code for v8 tester-only bots. None of the v8 masters set slave_type; this was added almost 3 years ago ( https://codereview.chromium.org/4079003 ) and was used back then, but isn't any more. BUG=305702 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=227922

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M build/scripts/master/factory/v8_commands.py View 1 chunk +0 lines, -9 lines 0 comments Download
M build/scripts/master/factory/v8_factory.py View 3 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
7 years, 2 months ago (2013-10-09 19:36:42 UTC) #1
Yang
I think Michael has more experience on bots.
7 years, 2 months ago (2013-10-10 08:09:29 UTC) #2
Michael Achenbach
LGTM. Not used at the moment. We might soon need to extract our ARM archive ...
7 years, 2 months ago (2013-10-10 12:58:53 UTC) #3
Nico
I'll hit CQ on this now. On Oct 10, 2013 5:58 AM, <machenbach@chromium.org> wrote: > ...
7 years, 2 months ago (2013-10-10 13:21:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/26399003/2001
7 years, 2 months ago (2013-10-10 13:21:55 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-10 13:22:43 UTC) #6
Message was sent while issue was closed.
Change committed as 227922

Powered by Google App Engine
This is Rietveld 408576698