Issue 4079003: Initial new v8 setup, this does not include windows setup. I will add this se...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4079003: Initial new v8 setup, this does not include windows setup. I will add this se... (Closed)

Created:
10 years, 2 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Nicolas Sylvain, nsylvain

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/build/

Visibility:
Public.

Description

Initial new v8 setup, this does not include windows setup. I will add this setup in a seperate change - this is just to sanety check all the linux builders. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63755

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 6

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+296 lines, -109 lines)			Patch
M	masters/master.client.v8/master.cfg	View	1	13 chunks	+139 lines, -80 lines	3 comments	Download
M	masters/master.client.v8/slaves.cfg	View	1	3 chunks	+37 lines, -4 lines	0 comments	Download
M	scripts/master/factory/v8_commands.py	View		4 chunks	+86 lines, -17 lines	3 comments	Download
M	scripts/master/factory/v8_factory.py	View		6 chunks	+34 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

nsylvain

10 years, 2 months ago (2010-10-25 20:24:49 UTC) #2

Took a quick look

mostly lgtm with nits

when you say "linux 32" in slaves.cfg, is that Linux Hardy 32 ?

http://codereview.chromium.org/4079003/diff/3001/4001
File masters/master.client.v8/master.cfg (right):

http://codereview.chromium.org/4079003/diff/3001/4001#newcode99
masters/master.client.v8/master.cfg:99: branch='bleeding_edge',
weird spacing

http://codereview.chromium.org/4079003/diff/3001/4001#newcode104
masters/master.client.v8/master.cfg:104: s_v8_arm_builder,
weird spacing

http://codereview.chromium.org/4079003/diff/3001/4001#newcode112
masters/master.client.v8/master.cfg:112: builderNames=['V8 Fuzzer',
weird spacing

http://codereview.chromium.org/4079003/diff/3001/4003
File scripts/master/factory/v8_commands.py (right):

http://codereview.chromium.org/4079003/diff/3001/4003#newcode80
scripts/master/factory/v8_commands.py:80: self.AddTaskkillStep();
no ";"

http://codereview.chromium.org/4079003/diff/3001/4003#newcode108
scripts/master/factory/v8_commands.py:108: self.AddTaskkillStep();
no ";"

http://codereview.chromium.org/4079003/diff/3001/4003#newcode153
scripts/master/factory/v8_commands.py:153: def AddArchiveBuild(self, mode='dev',
show_url=True, extra_archive_paths=None):
80 chars

Expand Messages | Collapse Messages