Fix unused lambda captures in //device and //services/media_capture.

Fix unused lambda captures in //device and //services/media_capture.

Clang just got a new warning about unused lambda captures,
and that requires us to clean all places with this issue
across all the Chromium code base. This CL fixes all such
cases in //device and //services/media_capture.

An example of a code that is no longer considered normal is

auto g = [i, j]() { printf("%d\n", i); };

in which j is never used in the lambda and therefore its capture is unnecessary.

This is a second attempt to submit this CL. Previous one
was reverted because of (now fixed) Windows issues.
The original review url:
https://codereview.chromium.org/2649443002/

BUG=681136
Review-Url: https://codereview.chromium.org/2639883006
Cr-Commit-Position: refs/heads/master@{#445418}
Committed: https://chromium.googlesource.com/chromium/src/+/2f1771ac371b74ddfff193a764dfea08b4a86314

[krasin1, 2017-01-20 15:56:06]

The CQ bit was checked by krasin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 15:56:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 16:06:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 16:06:12]

Dry run: This issue passed the CQ dry run.

[krasin1, 2017-01-20 16:28:36]

krasin@chromium.org changed reviewers:
+ rockot@chromium.org

[krasin1, 2017-01-20 16:28:36]

Hi Ken,

I have fixed the Windows-related issue with the CL that caused a revert
yesterday. The underlying issue was that *all* of the MSVC++ trybots in the CQ
don't ever run //services/video_capture:video_capture_unittests

I have manually added various Windows trybots (including all optional), and
found one that compiled the target:
https://build.chromium.org/p/tryserver.chromium.win/builders/win_archive/buil...

[6020/6027] CXX
obj/services/video_capture/video_capture_unittests/fake_device_unittest.obj

Quite possibly, we should add video_capture_unittests to some of the trybots.
Let me know, if you feel it's a good idea to bundle it with the CL, and I will
do it.

[Ken Rockot(use gerrit already), 2017-01-20 21:14:12]

LGTM as-is

[krasin1, 2017-01-23 18:23:37]

The CQ bit was checked by krasin@chromium.org

[commit-bot: I haz the power, 2017-01-23 18:24:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 18:39:08]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485195817447040,
"parent_rev": "8a8b6c2b28a210ca37a500d7e95572ce6126994d", "commit_rev":
"2f1771ac371b74ddfff193a764dfea08b4a86314"}

[commit-bot: I haz the power, 2017-01-23 18:39:40]

Description was changed from

==========
Fix unused lambda captures in //device and //services/media_capture.

Clang just got a new warning about unused lambda captures,
and that requires us to clean all places with this issue
across all the Chromium code base. This CL fixes all such
cases in //device and //services/media_capture.

An example of a code that is no longer considered normal is

auto g = [i, j]() { printf("%d\n", i); };

in which j is never used in the lambda and therefore its capture is unnecessary.

This is a second attempt to submit this CL. Previous one
was reverted because of (now fixed) Windows issues.
The original review url:
https://codereview.chromium.org/2649443002/

BUG=681136
==========

to

==========
Fix unused lambda captures in //device and //services/media_capture.

Clang just got a new warning about unused lambda captures,
and that requires us to clean all places with this issue
across all the Chromium code base. This CL fixes all such
cases in //device and //services/media_capture.

An example of a code that is no longer considered normal is

auto g = [i, j]() { printf("%d\n", i); };

in which j is never used in the lambda and therefore its capture is unnecessary.

This is a second attempt to submit this CL. Previous one
was reverted because of (now fixed) Windows issues.
The original review url:
https://codereview.chromium.org/2649443002/

BUG=681136

Review-Url: https://codereview.chromium.org/2639883006
Cr-Commit-Position: refs/heads/master@{#445418}
Committed:
https://chromium.googlesource.com/chromium/src/+/2f1771ac371b74ddfff193a764df...
==========

[commit-bot: I haz the power, 2017-01-23 18:39:41]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2f1771ac371b74ddfff193a764df...