Handle correctly "ShouldWait" result of mojo::Wait() in WebDataConsumerHandleImpl.

Handle correctly "ShouldWait" result of mojo::Wait() in WebDataConsumerHandleImpl.

This patch https://codereview.chromium.org/2363963002 changed
WebDataConsumerHandleImpl::ReaderImpl::read() to use mojo::Wait() when |size| is
zero.
But the patch didn't correctly handle MOJO_RESULT_DEADLINE_EXCEEDED result.
This method reutrns "UnexpectedError" but it should return "ShouldWait".

BUG=649558
Review-Url: https://codereview.chromium.org/2639873002
Cr-Commit-Position: refs/heads/master@{#444644}
Committed: https://chromium.googlesource.com/chromium/src/+/b8ea98da1ed38f6508a0b0c9928bc747e20c1731

[horo, 2017-01-18 06:18:25]

horo@chromium.org changed reviewers:
+ yhirano@chromium.org

[horo, 2017-01-18 06:18:26]

yhirano@
Could you please review this?

[horo, 2017-01-18 06:20:33]

Description was changed from

==========
Handle correctly "ShouldWait" result of mojo::Wait() in
WebDataConsumerHandleImpl.

This patch https://codereview.chromium.org/2363963002 changed
WebDataConsumerHandleImpl::ReaderImpl::read() to use mojo::Wait() when |size| is
zero.
But the patch doesn't correctly handle MOJO_RESULT_DEADLINE_EXCEEDED result.
This method reutrns UnexpectedError but it should return "ShouldWait".

BUG=649558
==========

to

==========
Handle correctly "ShouldWait" result of mojo::Wait() in
WebDataConsumerHandleImpl.

This patch https://codereview.chromium.org/2363963002 changed
WebDataConsumerHandleImpl::ReaderImpl::read() to use mojo::Wait() when |size| is
zero.
But the patch doesn't correctly handle MOJO_RESULT_DEADLINE_EXCEEDED result.
This method reutrns "UnexpectedError" but it should return "ShouldWait".

BUG=649558
==========

[horo, 2017-01-18 06:26:02]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 06:26:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 07:13:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 07:14:00]

Dry run: This issue passed the CQ dry run.

[yhirano, 2017-01-18 08:34:21]

Thanks!

https://codereview.chromium.org/2639873002/diff/1/content/child/web_data_cons...
File content/child/web_data_consumer_handle_impl.cc (right):

https://codereview.chromium.org/2639873002/diff/1/content/child/web_data_cons...
content/child/web_data_consumer_handle_impl.cc:74: return UnexpectedError;
NOTREACHED() according to
https://cs.chromium.org/chromium/src/mojo/public/c/system/functions.h?q=MOJO_...
?

[horo, 2017-01-18 09:37:08]

Thank you

https://codereview.chromium.org/2639873002/diff/1/content/child/web_data_cons...
File content/child/web_data_consumer_handle_impl.cc (right):

https://codereview.chromium.org/2639873002/diff/1/content/child/web_data_cons...
content/child/web_data_consumer_handle_impl.cc:74: return UnexpectedError;
On 2017/01/18 08:34:21, yhirano wrote:
> NOTREACHED() according to
>
https://cs.chromium.org/chromium/src/mojo/public/c/system/functions.h?q=MOJO_...
> ?

Done.

[horo, 2017-01-18 09:37:09]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 09:37:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 10:26:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 10:26:34]

Dry run: This issue passed the CQ dry run.

[horo, 2017-01-18 12:50:57]

Description was changed from

==========
Handle correctly "ShouldWait" result of mojo::Wait() in
WebDataConsumerHandleImpl.

This patch https://codereview.chromium.org/2363963002 changed
WebDataConsumerHandleImpl::ReaderImpl::read() to use mojo::Wait() when |size| is
zero.
But the patch doesn't correctly handle MOJO_RESULT_DEADLINE_EXCEEDED result.
This method reutrns "UnexpectedError" but it should return "ShouldWait".

BUG=649558
==========

to

==========
Handle correctly "ShouldWait" result of mojo::Wait() in
WebDataConsumerHandleImpl.

This patch https://codereview.chromium.org/2363963002 changed
WebDataConsumerHandleImpl::ReaderImpl::read() to use mojo::Wait() when |size| is
zero.
But the patch didn't correctly handle MOJO_RESULT_DEADLINE_EXCEEDED result.
This method reutrns "UnexpectedError" but it should return "ShouldWait".

BUG=649558
==========

[horo, 2017-01-18 23:45:06]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 23:45:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2017-01-18 23:45:42]

Patchset #3 (id:40001) has been deleted

[commit-bot: I haz the power, 2017-01-18 23:48:31]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[commit-bot: I haz the power, 2017-01-18 23:53:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 23:53:52]

Dry run: This issue passed the CQ dry run.

[yhirano, 2017-01-19 02:15:46]

lgtm

[horo, 2017-01-19 02:25:36]

horo@chromium.org changed reviewers:
+ kinuko@chromium.org

[horo, 2017-01-19 02:25:37]

kinuko@
Could you please review this?

[kinuko, 2017-01-19 04:33:58]

lgtm

[horo, 2017-01-19 04:40:04]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2017-01-19 04:40:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 04:44:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484800804522060,
"parent_rev": "0e85e9249f98fdfe2bcff21d4721526600409848", "commit_rev":
"b8ea98da1ed38f6508a0b0c9928bc747e20c1731"}

[commit-bot: I haz the power, 2017-01-19 04:44:56]

Description was changed from

==========
Handle correctly "ShouldWait" result of mojo::Wait() in
WebDataConsumerHandleImpl.

This patch https://codereview.chromium.org/2363963002 changed
WebDataConsumerHandleImpl::ReaderImpl::read() to use mojo::Wait() when |size| is
zero.
But the patch didn't correctly handle MOJO_RESULT_DEADLINE_EXCEEDED result.
This method reutrns "UnexpectedError" but it should return "ShouldWait".

BUG=649558
==========

to

==========
Handle correctly "ShouldWait" result of mojo::Wait() in
WebDataConsumerHandleImpl.

This patch https://codereview.chromium.org/2363963002 changed
WebDataConsumerHandleImpl::ReaderImpl::read() to use mojo::Wait() when |size| is
zero.
But the patch didn't correctly handle MOJO_RESULT_DEADLINE_EXCEEDED result.
This method reutrns "UnexpectedError" but it should return "ShouldWait".

BUG=649558

Review-Url: https://codereview.chromium.org/2639873002
Cr-Commit-Position: refs/heads/master@{#444644}
Committed:
https://chromium.googlesource.com/chromium/src/+/b8ea98da1ed38f6508a0b0c9928b...
==========

[commit-bot: I haz the power, 2017-01-19 04:44:57]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b8ea98da1ed38f6508a0b0c9928b...