PPC/s390: Check for overflow when SubI IntMin

PPC/s390: Check for overflow when SubI IntMin

R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
BUG=
LOG=N

Review-Url: https://codereview.chromium.org/2639853002
Cr-Commit-Position: refs/heads/master@{#42468}
Committed: https://chromium.googlesource.com/v8/v8/+/d794ef7db5de8ebcbd6182923c960b23bffbaadd

[JaideepBajwa, 2017-01-18 05:49:24]

ptal

[john.yan, 2017-01-18 15:24:58]

lgtm with suggestion.

https://codereview.chromium.org/2639853002/diff/1/src/crankshaft/s390/lithium...
File src/crankshaft/s390/lithium-codegen-s390.cc (right):

https://codereview.chromium.org/2639853002/diff/1/src/crankshaft/s390/lithium...
src/crankshaft/s390/lithium-codegen-s390.cc:1692: __ Sub32(ToRegister(result),
scratch0());
maybe we can use: __ Sub32(ToRegister(result), ToRegister(left), scratch0());
it may generate srk when available.

[JaideepBajwa, 2017-01-18 16:27:09]

On 2017/01/18 15:24:58, john.yan wrote:
> lgtm with suggestion.
> 
>
https://codereview.chromium.org/2639853002/diff/1/src/crankshaft/s390/lithium...
> File src/crankshaft/s390/lithium-codegen-s390.cc (right):
> 
>
https://codereview.chromium.org/2639853002/diff/1/src/crankshaft/s390/lithium...
> src/crankshaft/s390/lithium-codegen-s390.cc:1692: __ Sub32(ToRegister(result),
> scratch0());
> maybe we can use: __ Sub32(ToRegister(result), ToRegister(left), scratch0());
> it may generate srk when available.

done, thanks!

[JaideepBajwa, 2017-01-18 16:27:14]

The CQ bit was checked by bjaideep@ca.ibm.com

[JaideepBajwa, 2017-01-18 16:27:14]

The patchset sent to the CQ was uploaded after l-g-t-m from jyan@ca.ibm.com
Link to the patchset: https://codereview.chromium.org/2639853002/#ps20001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-01-18 16:27:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 16:51:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484756834191770,
"parent_rev": "dd789d87f9508d3cca11e86b71657641261e99b5", "commit_rev":
"d794ef7db5de8ebcbd6182923c960b23bffbaadd"}

[commit-bot: I haz the power, 2017-01-18 16:51:16]

Description was changed from

==========
PPC/s390: Check for overflow when SubI IntMin

R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
BUG=
LOG=N
==========

to

==========
PPC/s390: Check for overflow when SubI IntMin

R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
BUG=
LOG=N

Review-Url: https://codereview.chromium.org/2639853002
Cr-Commit-Position: refs/heads/master@{#42468}
Committed:
https://chromium.googlesource.com/v8/v8/+/d794ef7db5de8ebcbd6182923c960b23bff...
==========

[commit-bot: I haz the power, 2017-01-18 16:51:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/d794ef7db5de8ebcbd6182923c960b23bff...